Closed Bug 409611 Opened 16 years ago Closed 16 years ago

nsMailModule.cpp:1278: warning: large integer implicitly truncated to unsigned type

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

The fix
639 bytes, patch
neil
: review+
neil
: superreview+
Details | Diff | Splinter Review
Attached patch The fix — — Splinter Review 
Regression from bug 379070:

nsMailModule.cpp:1278: warning: large integer implicitly truncated to unsigned type

After a lot of experimentation to find the wrong item in nsMailModule.cpp, I then found:

 125 #define NS_MESSENGER_CID \
 126 { /* f436a174-e2c0-4955-9afe-e3feb68aee56 */      \
 127   0xf436a174, 0xe2c0, 0x4955,                     \
 128     {0x9af, 0xe3, 0xe, 0xfe, 0xb6, 0x8a, 0xee, 0x56}}

This should be:

 125 #define NS_MESSENGER_CID \
 126 { /* f436a174-e2c0-4955-9afe-e3feb68aee56 */      \
 127   0xf436a174, 0xe2c0, 0x4955,                     \
 128     {0x9a, 0xfe, 0xe3, 0xfe, 0xb6, 0x8a, 0xee, 0x56}}

(in other words the first version has the first three items of the second part wrong).

I think we've probably just got away with it and I doubt that its caused any real problems.
Attachment #294415 - Flags: superreview?(neil)
Attachment #294415 - Flags: review?(neil)
Comment on attachment 294415 [details] [diff] [review]
The fix

Good catch!
Attachment #294415 - Flags: superreview?(neil)
Attachment #294415 - Flags: superreview+
Attachment #294415 - Flags: review?(neil)
Attachment #294415 - Flags: review+
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.