409611 - nsMailModule.cpp:1278: warning: large integer implicitly truncated to unsigned type

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Regression from bug 379070:

nsMailModule.cpp:1278: warning: large integer implicitly truncated to unsigned type

After a lot of experimentation to find the wrong item in nsMailModule.cpp, I then found:

 125 #define NS_MESSENGER_CID \
 126 { /* f436a174-e2c0-4955-9afe-e3feb68aee56 */      \
 127   0xf436a174, 0xe2c0, 0x4955,                     \
 128     {0x9af, 0xe3, 0xe, 0xfe, 0xb6, 0x8a, 0xee, 0x56}}

This should be:

 125 #define NS_MESSENGER_CID \
 126 { /* f436a174-e2c0-4955-9afe-e3feb68aee56 */      \
 127   0xf436a174, 0xe2c0, 0x4955,                     \
 128     {0x9a, 0xfe, 0xe3, 0xfe, 0xb6, 0x8a, 0xee, 0x56}}

(in other words the first version has the first three items of the second part wrong).

I think we've probably just got away with it and I doubt that its caused any real problems.

Comment 1

[[e-mail]]

Comment on attachment 294415 [details] [diff] [review]
The fix

Good catch!

Comment 2

[Mark Banner (:standard8)]

Patch checked in -> fixed.