409800 - Make the new pageInfo window more friendly to extensions

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Philip Chee]

Attachment: Restores the id to the <tabs> element

In Gecko 1.8 browsers the <tabs> element in the pageInfo window of both Firefox and SeaMonkey had an id (of "tabs") this allowed extensions to overlay the window to add their own UI.

In Firefox 3.0b1 the <radiogroup> has an id="viewGroup" which does the same thing. Unfortunately SeaMonkey's version of the new pageInfo window removed the id on the <tabs> making it very difficult for extensions to add their own tab panels.

This patch restores the ID and is a one line nobrainer. Tested with a modified version of the Named Anchors extension found at: <http://xsidebar.mozdev.org/modifiedmisc.html#namedanchors>

Comment 1

[Philip Chee]

Attachment: Restores the IDs to the <tabbox> and <tabs> elements

the <tabbox> should not have an ID of "viewGroup" since it is not a radio group. Reverting to the ID used in SeaMonkey 1.0/1.1 which is simply "tabbox".

Reason: PageInfo extensions that work in both Firefox and SeaMonkey try to overlay "viewGroup" to add their radio buttons to the Firefox PageInfo window. But this causes non-functioning radio buttons to accumulate at the bottom of the SeaMonkey 2.0 PageInfo window.

Comment 2

[Philip Chee]

Attachment: Corrected Patch: Restores the IDs to the <tabbox> and <tabs> elements

Missed out the pageInfo.js file from the previous diff.

Comment 3

[Daniel Brooks [:db48x]]

Comment on attachment 294564 [details] [diff] [review]
Corrected Patch: Restores the IDs to the <tabbox> and <tabs> elements

Ahh, thanks for noticing this Philip. r=db48x

Comment 4

[Robert Kaiser]

Comment on attachment 294564 [details] [diff] [review]
Corrected Patch: Restores the IDs to the <tabbox> and <tabs> elements

Checked in per request from Philip via IRC.