409925 - editors_notice_none_found accepts a non-localizable string

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Wil Clouser [:clouserw]]

The code in editors_controller uses $mode to determine if it's looking at the nominated, pending or review portion of the queue.  This string is used from the URL and it's also passed directly to the view and used in the _() call.  The relevant portion of the .po:

# %1 is the queue mode
#: views/admin/flagged_queue.thtml:67 views/editors/queue.thtml:105                                 
#, php-format              
msgid "editors_notice_none_found"
msgstr "There are currently no %s add-ons to review."

An easy fix would be to change the msgstr to "There is currently nothing to review." since passing in "reviews" doesn't really make sense right now anyway.  We could probably target this for the upcoming string change.

Comment 1

[Michael Morgan [:morgamic]]

Wil -- can you resolve this today?

Comment 2

[Wil Clouser [:clouserw]]

r10377.  Just have to remember to tell the localizers this string changed.