409964 - Clean up some requires and includes in mailnews backend.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I did this originally to help clarify what depends on what in the backend as it may help with some of the frozen api migration (I want to see if I can do builds with reduced mailnews components to see what problems we're likely to get).

The main thing we gain is the reduction in some REQUIRES. The main one of these is caused by including nsIMsgDatabase.h (from msgdb) in nsIMsgFolder.idl (from mailnews/base) when we don't need to.

Although this means we need to include more items elsewhere, I think overall it will make the picture clearer.

The rest of it is header include adjustments to cope with the include removal from the idl, and one or two removals for things that are not necessary in some files.

Comment 1

[Mark Banner (:standard8)]

I forgot to mention, I've only tried this on Linux and not Windows/Mac. Any problems should be obvious though.

Comment 2

[[e-mail]]

Comment on attachment 294654 [details] [diff] [review]
The fix

Just one Windows file failed to compile; you'd better get Mac tested too:
C:\mozilla\mailnews\import\eudora\src\nsEudoraWin32.cpp(230) : error C3861: 'PR_Malloc': identifier not found, even with argument-dependent lookup
C:\mozilla\mailnews\import\eudora\src\nsEudoraWin32.cpp(242) : error C3861: 'PR_Free': identifier not found, even with argument-dependent lookup
C:\mozilla\mailnews\import\eudora\src\nsEudoraWin32.cpp(455) : warning C4244: 'argument' : conversion from 'PRInt64' to 'PRUint32', possible loss of data
C:\mozilla\mailnews\import\eudora\src\nsEudoraWin32.cpp(1130) : error C3861: 'PL_strcasecmp': identifier not found, even with argument-dependent lookup

Comment 3

[Rich Gray (:rbgray)]

with Neil's guidance on How To Patch, make -C mailnews WFM.  
Building with Xcode 3.0 under OS X 10.5.1 Leopard.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> with Neil's guidance on How To Patch, make -C mailnews WFM.  
> Building with Xcode 3.0 under OS X 10.5.1 Leopard.

Thanks Rich.

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix v2

This should fix the windows compilation problems.

Comment 6

[Mark Banner (:standard8)]

Patch checked in -> fixed.