Closed Bug 409971 Opened 17 years ago Closed 17 years ago

remove warning on jar creation

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: ynvich, Assigned: ynvich)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2) Gecko/2007122022 Firefox/3.0b2
Build Identifier: gecko-1.9b2

A warning is produced for each newly created jar archive. This happens, because config/make-jars.pl uses '-uX' zip options to add files to jar, even if the jar doesn't exist.

Reproducible: Always

Steps to Reproduce:
Run 'make -f client/mk' on a clean tree.

Actual Results:  
zip warning is logged

Expected Results:  
nothing happens

Patch follows.
Attached patch proposed fixSplinter Review
This patch supplies '-u' to zip, only when the target jar exists.
Attachment #294660 - Flags: review?
Attachment #294660 - Flags: review? → review?(benjamin)
Assignee: nobody → ynvich
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #294660 - Flags: review?(benjamin) → review+
bsmedberg,

Thanks for r+. Should I also ask for sr and a from you, or someone else?
Status: NEW → ASSIGNED
Comment on attachment 294660 [details] [diff] [review]
proposed fix

You don't need sr, just approval at this point.
Attachment #294660 - Flags: approval1.9?
Attachment #294660 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Hardware: PC → All
Version: unspecified → Trunk
Checking in config/make-jars.pl;
/cvsroot/mozilla/config/make-jars.pl,v  <--  make-jars.pl
new revision: 3.95; previous revision: 3.94
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: