409998 - when right clicking - "Open All In Tabs" from history sidebar (when view by site) we open multiple copies of each item

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

Comment 1

[(not reading, please use [e-mail] instead)]

when right clicking - "Open All In Tabs" from history sidebar (when view by site) we open multiple copies of each item

the duplicate copies appear to be from visits.

see attached screen shot.

the problem might be in getURLsForContainerNode().

perhaps we're collapsing duplicates in the UI (tree view), but not using the same logic when determining urls in the container.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 3

[(not reading, please use [e-mail] instead)]

could be a regression from bug #399729:  "Reduce places viewa performance overhead", but I have not debugged or confirmed any of this (or my theory in comment #1).

found this while testing a fix for bug #409301, but firefox 3 b 2 has the same bug.

Comment 4

[Marco Bonardo [:mak]]

this is related to Bug 293513, there is a similar problem there, it's because PlacesUtils.getURLsForContainerNode gets also non visible urls

Comment 5

[Marco Bonardo [:mak]]

sorry, i was talking about Bug 402558

Comment 6

[Asaf Romano (gone)]

Attachment: patch

Comment 7

[Marco Bonardo [:mak]]

does that work when a folder is closed and you right click it and call open all in tabs?

i'm asking because in Bug 402558 i had to open the folder before calling openSelectionInTabs

Comment 8

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> does that work when a folder is closed and you right click it and call open all
> in tabs?
> 
> i'm asking because in Bug 402558 i had to open the folder before calling
> openSelectionInTabs
> 

OAIT menuitem is disabled when a container is closed.

Comment 9

[Asaf Romano (gone)]

mozilla/browser/components/places/content/utils.js 1.94

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b3pre) Gecko/2008020304 Minefield/3.0b3pre ID:2008020304

-> Verified

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv