Closed Bug 410055 Opened 17 years ago Closed 17 years ago

LAST-MODIFIED entries of all items in an ics file are set to actual time

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mttl, Assigned: dbo)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Lightning 0.8pre (2007122603) with Thunderbird 2.0.0.9 (20071031)

If you change one event in a remote calendar (ics-file) the LAST-MODIFIED entries of all items in this file are set to the actual time even though only one item was modified.

Reproducible: Always

Steps to Reproduce:
1. Change one item in a remote calendar (ics-file)
2. Open the ics-file with an editor
3.
Actual Results:  
All LAST-MODIFIED entries are set to the time when the item was changed.

Expected Results:  
Only the LAST-MODIFIED entry of the modified item should be set to the actual time.
Attached patch fix — — Splinter Review
Problem is that while filling up the memory calendar (addItem), an item's generation is forced to 1 which causes the item to be modified. I don't see a reason why X-MOZILLA-GENERATION shouldn't persist even in case the item is added, so this fix just removes those lines from calStorageCalendar and calMemoryCalendar. A further problem I've been facing is that X-MOZILLA-GENERATION is currently broken (the generation check is useless); I've fixed that, too.
Assignee: nobody → daniel.boelzle
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #294733 - Flags: review?(mvl)
We shouldn't reset LAST-MODIFIED stamps since this may cause additional overhead when interoperating with other apps. => wanted-0.8
Flags: wanted-calendar0.8+
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 294733 [details] [diff] [review]
fix

looks good
r=mvl
Attachment #294733 - Flags: review?(mvl) → review+
Attached patch fix -- X-MOZ-GENERATION — — Splinter Review
Since that generation stuff has been broken anyway... IMO we should align the prefix, i.e. rename X-MOZILLA-GENERATION to X-MOZ-GENERATION, too.
Any objections?
Attachment #295096 - Flags: review?(mvl)
Comment on attachment 295096 [details] [diff] [review]
fix -- X-MOZ-GENERATION

looks good too
r=mvl
Attachment #295096 - Flags: review?(mvl) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Checked in latest nightly build -> task is fixed and verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: