410150 - nsCacheService: only add observers that we really need

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Alfred Kayser]

Attachment: V1: Use array/for loops for the Add/Remove observers

1. Make better use of arrays and for loops to do the AddObserver/RemoveObserver calls.
2. Place the ifdef NECKO_OFFLINE_CACHE at the right locations.
3. Only Add/Remove observers for those types of cache that are build enabled.

This saves some code in general (±1.5K objectsize), but even more when compiling without DISK/OFFLINE caches, in which case also less observers are registered.

Comment 1

[Jo Hermans]

     static char * prefList[]
might be better as :
     static const char * prefList[]

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Do we need the sr on this? I'd be more comfortable with it, but don't know how available biesi is these days.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 294817 [details] [diff] [review]
V1: Use array/for loops for the Add/Remove observers

Can't approve without appropriate sr ...

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 294817 [details] [diff] [review]
V1: Use array/for loops for the Add/Remove observers

+        if (NS_FAILED(rv)) rv2 = rv;

while you're here, please put the body of the if on its own line

+        for (int i=0; i<NS_ARRAY_LENGTH(prefList); i++) {
+            // remove Disk cache pref observers

it's not only disk cache observers you're removing...

Comment 5

[Alfred Kayser]

Attachment: V2: With the comments cbiesinger incorporated: ready for checkin

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 301852 [details] [diff] [review]
V2: With the comments cbiesinger incorporated: ready for checkin

a1.9+=damons

Comment 7

[Reed Loden [:reed] (use needinfo?)]

Checking in netwerk/cache/src/nsCacheService.cpp;
/cvsroot/mozilla/netwerk/cache/src/nsCacheService.cpp,v  <--  nsCacheService.cpp
new revision: 1.118; previous revision: 1.117
done

Comment 8

[Alfred Kayser]

Verified:
  libnecko.so
  	Total:	       -192 (+64/-256)
  	Code:	       -212 (+0/+0)
  	Data:	        +20 (+64/-256)
  	        +32 (+64/-32)	data.rel.ro (DATA)
  		        +32 (+64/-32)	UNDEF:libnecko.so:data.rel.ro
  			        +32	prefList
  			        +20	.nosyms.data.rel.ro
  			        +12	observerList
  			        -32	nsCacheProfilePrefObserver::Install()::C.260
  	       -224 (+0/-224)	text (DATA)
  		       -224 (+0/-224)	UNDEF:libnecko.so:text
  			        -12	.nosyms.text
  			        -62	nsCacheProfilePrefObserver::Install()
  			       -150	nsCacheProfilePrefObserver::Remove()