EXTRA_PP_COMPONENTS and EXTRA_PP_JS_MODULES fail if the target directory does not already exist

RESOLVED FIXED in mozilla1.9beta3

Status

RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla1.9beta3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 294899 [details] [diff] [review]
create directories first

Piping to the non-existant directory causes the build to fail. This patch just ensures the directory exists first.
Attachment #294899 - Flags: review?(ted.mielczarek)
Attachment #294899 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

11 years ago
Comment on attachment 294899 [details] [diff] [review]
create directories first

Looking for approval for this minor build config change. Shouldn't affect any currently building apps but makes life a little easier for new small apps using our build system that may only have one component/module.
Attachment #294899 - Flags: approval1.9?
Assignee: nobody → dtownsend
(Assignee)

Updated

11 years ago
Whiteboard: [has patch]
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Comment on attachment 294899 [details] [diff] [review]
create directories first

a=beltzner for 1.9
Attachment #294899 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 3

11 years ago
Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.581; previous revision: 3.580
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch]
(Assignee)

Updated

11 years ago
Target Milestone: --- → mozilla1.9 M11

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.