410280 - Some constants can be exported from the main application for use in prefpanes

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[Mark Mentovai]

Spun off from bug 409760 comments 5-6:

>Comment #5 [reply] Smokey Ardisson 2007-12-26 20:49:20 PST
[...]
>Out of curiosity (and since it was about the only thing I could follow in
>the patch), why are you removing
>
>> -const int kDefaultExpireDays = 9;
>
>from General; is it unused in General? I notice we declare that in 4 files
>on the branch: prefPanes Downloads.mm, General.mm, and History.mm, and
>src/history/HistoryDataSource.mm

>Comment #6 [reply] Mark Mentovai 2007-12-27 06:29:04 PST
>It's unused in General and Downloads.
>
>In History, it should either
> - (better) be changed to static, or
> - (best) be changed to extern,
>   and the one in HistoryDataSource should be changed to export (not static),
>   so that the constant is properly shared.  Thanks, -bundle_loader!
>
>There are other instances where we have constants that can be shared.  Even
>the static strings that I've done in General can be in the application itself
>and shared.

When I checked the patch in bug 409760 in, I got rid of the unused constant in Downloads in addition to the removal in General, and I implemented (better) for History.  We can change this to implement (best) and do the same with other shareable data.