410298 - Currently viewed application should not appear in "Other Applications" dropdown

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: "Other Applications" dropdown should probably not include Firefox when chosen app/view is Firefox

Steps to Reproduce:

1. Log on to https://remora-reskin.stage.mozilla.com/en-US/firefox/
2. Click the "Other Applications" dropdown

Actual Results:

When in the /firefox view, it shows:
SeaMonkey
Sunbird
Thunderbird
Firefox

If "Firefox" should appear (note that it doesn't on http://mozilla.focalcurve.com) when in the Firefox view, then it should at least have its icon in the dropdown; as it stands, we probably should remove "Firefox" from the choice when it's the currently viewed app.

Madhava: what say you?

Comment 1

[Madhava Enros [:madhava]]

That's right -- the currently featured application should not be in the dropdown.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Adjusting summary from "'Other Applications' dropdown should probably not include Firefox when chosen app/view is Firefox" to "Currently viewed application should not appear in "Other Applications" dropdown", since this affects Sunbird, Thunderbird, and SeaMonkey, too.

Comment 3

[Fred Wenzel [:wenzel]]

What order do they have, anyway? In terms of likelyhood what people could be looking for when clicking that button, I'd suggest the order Fx, Tb, Sm, Sb. The new one seems slightly random to me, or am I missing something?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

They're currently in alphabetical order, which matches the spec's mockups at http://people.mozilla.com/~madhava/files/amo/2007-11-21/; I'm not suggesting that they stay in that order, though.

Comment 5

[Fred Wenzel [:wenzel]]

Ah, okay; yeah I don't think that's the best order (and why is Fx at the bottom then? weird). Do we need a new bug for that?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Ah, okay; yeah I don't think that's the best order (and why is Fx at the bottom
> then? weird). Do we need a new bug for that?

That's what this whole bug is about; see comment 1 and comment 2 :-)

Comment 7

[Fred Wenzel [:wenzel]]

Actually no, it's not about the weird app picker order that you get in all applications' pages. I filed bug 411642. Should be an easy fix :)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Actually no, it's not about the weird app picker order that you get in all
> applications' pages. I filed bug 411642. Should be an easy fix :)

Sorry, I was responding to, "(and why is Fx at the bottom
then? weird). Do we need a new bug for that?"

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #8)
> Sorry, I was responding to, "(and why is Fx at the bottom
> then? weird). Do we need a new bug for that?"

Ah, sorry for the misunderstanding. I meant it is out of order, even alphabetically.

Comment 10

[Fred Wenzel [:wenzel]]

I fixed this in the 3.2 redesign branch, SVN r9794.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using IE 6/7, Safari 3.04, Firefox 2.0.0.11 and Opera 9.25 (Windows, with Mac testing in Safari and Firefox).