410444 - nsTDependentString_CharT crash in NS_ASSERTION

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Alex Vincent [:WeirdAl]]

NS_ASSERTION(mData, "nsTDependentString must wrap a non-NULL buffer");
NS_ASSERTION(mLength != size_type(-1), "nsTDependentString has bogus length");
NS_ASSERTION(mData[mLength] == 0, "nsTDependentString must wrap only null-terminated strings");

If either the first or the second assertion fails, we crash.

Comment 1

[Jesse Ruderman]

Is that a problem?  If the first or second assertion fails, isn't something already very wrong?

Comment 2

[Alex Vincent [:WeirdAl]]

Attachment: patch

I agree the assertion failure in the first place is a Very Bad Thing, and it should be investigated.  (The case I hit, and I've yet to try reproducing on trunk, involved Microsoft Silverlight.)  But when I hit this crash, I was trying to debug something else, and this proved a distraction.

Comment 3

[Benjamin Smedberg]

Comment on attachment 295067 [details] [diff] [review]
patch

The assertions are correct, and it's better to crash at this point than wallpaper over it.

Comment 4

[Alex Vincent [:WeirdAl]]

Is this bug a WONTFIX then?

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to comment #3)
> (From update of attachment 295067 [details] [diff] [review])
> The assertions are correct, and it's better to crash at this point than
> wallpaper over it.

bsmedberg, WONTFIX?