replace nsSimpleUInt32Array with nsTArray<DWORD>

RESOLVED FIXED

Status

MailNews Core
Import
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
MapiMessage rolls its own array class, which we can replace wth nsTArray.
(Assignee)

Comment 1

10 years ago
Created attachment 295085 [details] [diff] [review]
Proposed patch
Attachment #295085 - Flags: superreview?(bienvenu)
Attachment #295085 - Flags: review?(bienvenu)
(Assignee)

Comment 2

10 years ago
Created attachment 295090 [details] [diff] [review]
-w version
(Assignee)

Comment 3

10 years ago
Created attachment 295205 [details] [diff] [review]
Fixed patch

Whoops, after compiling I thought "hey, I forgot to remove the class decl" but forgot to remove the impl too...
Assignee: nobody → neil
Attachment #295085 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #295205 - Flags: superreview?(bienvenu)
Attachment #295205 - Flags: review?(bienvenu)
Attachment #295085 - Flags: superreview?(bienvenu)
Attachment #295085 - Flags: review?(bienvenu)

Comment 4

10 years ago
See also bug 258018 where there is already an patch to do this for MapiMessage.
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
>See also bug 258018 where there is already an patch to do this for MapiMessage.
Yes, but this patch was first, and the other patch doesn't belong there anyway.

Comment 6

10 years ago
Comment on attachment 295205 [details] [diff] [review]
Fixed patch

thx, Neil.
Attachment #295205 - Flags: superreview?(bienvenu)
Attachment #295205 - Flags: superreview+
Attachment #295205 - Flags: review?(bienvenu)
Attachment #295205 - Flags: review+
(Assignee)

Comment 7

10 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.