410512 - deleting an item in history sometimes selects item on top of the list

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P2)

Description

[Daniel.S]

In the History section of the Library, when I delete an item which is not the first on the list, sometimes not only the item followed by the deleted item is selected but the first item on the list as well.

STR:
1. Open the Library and go to History.
2. Select any but the topmost item on the list.
3. Press the Delete key a few times.

After some deletions the history-item on the top is randomly selected as well. It shouldn't get selected.

To be visual:

(first item)
(fellow item1)
[fellow item2] (selected)
(fellow item3)

Deleting the selected item results in:

[first item] (selected)
(fellow item1)
[fellow item3] (selected)

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008010209 Minefield/3.0b3pre

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression window is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1198170600&maxdate=1198178279 -> Bug 393870.

Comment 3

[Marco Bonardo [:mak]]

332047 could help here (should check after it's checked-in)

Comment 4

[Marco Bonardo [:mak]]

i can confirm that with patch in bug 332047 i cannot reproduce

Comment 5

[Asaf Romano (gone)]

We should fix this in PlacesTreeView by comparing the visit id.

Comment 6

[Asaf Romano (gone)]

Attachment: more selection work

Hopefully we'll get to remove the two other types by time for beta.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 296589 [details] [diff] [review]
more selection work

thanks, r=me.

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/content/controller.js 1.193
mozilla/browser/components/places/content/tree.xml 1.89
mozilla/browser/components/places/content/treeView.js 1.28

Comment 9

[Daniel.S]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008030206 Minefield/3.0b4pre ID:2008030206

This is not fixed. I just noticed this bug is still appears.

Here are STR that should work for everybody:
1. Create a new profile; middle click the Livemark to accumulate some history items.
2. In History-Library, select any item after the topmost one and delete it.

Results: The item on top of the list is unexpectedly selected.

It only happens sometimes, but often from my point of view.

Comment 10

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #9)
>
Confirmed, but it only seems to happen with the items without an icon and without tooltip. It behaves how it should with history items with a BBC icon, name and tooltip. I's not clear to me why only the half of the feed's sites has favicons.

Comment 11

[Mike Connor [:mconnor]]

This seems to WFM now, I can't reproduce on current Mac trunk, even with Ria's steps.

Comment 12

[Daniel.S]

Yeah, I also wasn't able to reproduce this on todays Win Nightly.

However, I noticed that sometimes when the last item in the list is deleted, the selection is lost instead of moving to the item that's the last one now. But it's possible that this is reported elsewhere.

Comment 13

[Mike Connor [:mconnor]]

Pretty sure it is, resolving WFM.

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv