41066 - JS_ExecuteScriptPart does not cooperate with JS debugger

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Brendan Eich [:brendan]]

From the URL:

1) i set a callback with JSD_SetThrowHook()
2) i executed a compiled script with JS_ExecuteScriptPart( .. JSEXEC_MAIN )
.
3) the JSD throw callback was not invoked on 'throw'.
4) this did work with JS_ExecuteScript

i looked inside the code. if i understood it correctly:
1) JSD uses JS_SetNewScriptHook() and JS_SetDestroyScriptHook() to set its
own callbacks.
2) JS_ExecuteScriptPart executes using a temporary JSScript object.
3) JS_ExecuteScriptPart does not call the callbacks (from step 1) on the
temporary JSScript.

can i use JSD_ScriptCreated() and JSD_ScriptDestroyed() somehow?

             "itaj sherman" <[e-mail]>

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

Comment 2

[Brendan Eich [:brendan]]

Roger, can you give me an r=?

/be

Comment 3

[Brendan Eich [:brendan]]

Fix checked in.

/be