410866 - Expose Tabsposé in the UI

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We need to expose Tabsposé in our UI (show cmd-ctrl-t in menu somewhere, toolbar icon) for 2.0.

Before we do that, we probably need to fix some or all of the remaining bugs (see the depends field).

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When we add this to the menu, we also need to be sure to remove the hard-coding of Cmd-Ctrl-t wherever that is set.

As for the name, I had been thinking "Tab Preview" or "Tab Thumbnails" or "Tab Thumbnail View".

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'd forgotten that "Tab Preview" or "Tab Thumbnails" without any modifier might be confusing since other applications use those terms for the little non-performant preview windows that pop up when you hover over a tab widget.

We could also try something with "Grid" in it.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

For comparison purposes, Shiira uses "Show All Tabs" in the Window menu, iCab uses "Tab Overview" in the Window menu, and Flare has "Expose all Tabs" in the View menu; all are Shiira-style Exposé.

Comment 4

[Stuart Morgan]

Attachment: add a menu item [landed]

Here's the code portion of adding a menu item, for which we settled on Show/Hide Tab Overview in the Window menu. Our feeling is that the remaining blockers to this bug are livable for an alpha, and getting it into the menu now will help us get exposure and flush out any remaining bugs.

Nib to follow once I boot my laptop into Tiger and remake it...

Comment 5

[Stuart Morgan]

Attachment: new nib [landed]

Corresponding nib. Contains the nib change for bug 438655 (but can land without that bug's changes with no ill effects).

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 339705 [details] [diff] [review]
add a menu item [landed]

sr=pink

Comment 7

[Stuart Morgan]

Comment on attachment 339705 [details] [diff] [review]
add a menu item [landed]

Landed on CVS trunk.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We'll need two or three strings here, and then presumably we can take our time actually hooking up the icon (I hope).

We might also want to implement this (or its tooltip) as show/hide, since it is a view like Bookmarks and since its menu item does that.

At minimum, we need this:

/* Button Labels */
"TabOverview" = "Tab Overview";

/* Customize Sheet Labels (where different) */

/* Button Tooltips */
"TabOverviewTooltip" = "Show Tab Overview";

Comment 9

[Stuart Morgan]

Attachment: toolbar item code

Here's the toolbar part, since it looks like we'll have the icon in soon.

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 349645 [details] [diff] [review]
toolbar item code

Yay!!!!! sr=pink

Comment 11

[Stuart Morgan]

Landed on CVS trunk; that's a wrap!