410966 - Look of sidebar resizer

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot

The look of the resizers in places organizer is fixed and at least the drag handle on the browser sidebar looks nice, now. But the browser sidebar is still missing borders. Also, I wonder if the very left side of the browser window should display some kind of border, just as the places organizer sidebar does?

Comment 1

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Make the sidebars trees have native appearance

It's not the resizer that lack borders, it's the objects touching it. In particular, the tree in the sidebar has only a top border. Culprit is in browser/themes/gnomestripe/browser/places/places.css:

"""
.sidebar-placesTree {
  -moz-appearance: none;
  border: 0;
  margin: 0;
  border-top: 1px solid ThreeDShadow;
}
"""

I think that just removing this rule makes it look good, since it then gets the right -moz-appearance... Patch attached

Comment 2

[Julien "_FrnchFrgg_" RIVAUD]

Note that the issue of the right border is still remaining.

Comment 3

[Michael Monreal [:micmon]]

Ouch, I looked at this problem from the wrong angle all the time! Tanks!

As for the other border, will this be fixed when the fix for bug 407775 lands? (at least for the case that a tab is open?)

Comment 4

[Julien "_FrnchFrgg_" RIVAUD]

Yes, when the tab bar is visible and if bug 407775 lands, it will be fixed. But without the tabs, I don't really know what to do.
(OT: are you on the irc channel ? #developers at irc.mozilla.org)

Comment 5

[Michael Monreal [:micmon]]

Then let's get bug 407775 (your middle variant rocks, did I mention that already *g*) landed first and then see how "without tabs" should look like.

Comment 6

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.22; previous revision: 1.21
done

File a new bug on any other issues?