411032 - ###!!! ASSERTION: gtkwidget.c:7322: widget class `GtkToolbar' has no property named `wide-separators': 'glib assertion', file nsSigHandlers.cpp, line 197

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Current Linux builds assert like crazy about there not being a 'wide-separators' property on toolbars.  I'm not sure why we make this an assert, while gtk thinks it's a warning.  This appears to be a regression from bug 406075 and it's making debugging absolutely miserable.  There's also the separate issue of unbridled console spew from gtk itself here, so I wonder whether it's possible to quiet that down too.

Comment 1

[Reed Loden [:reed]]

What version of GTK are you using?

http://live.gnome.org/Maemo/Gtk210Migration#line-90 says that wide-separators was added in 2.10, which is the minimum GTK+ version we "officially" support for Firefox 3, as per the Linux ref platform.

Comment 2

[Boris Zbarsky [:bzbarsky]]

2.6 and 2.8 on different machines.  I'll try to set up 2.10.  Doing it is a huge pain in the behind.  :(

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Michael, can you look into the issue of making the GTK warning turn into a regular XPCOM warning?

Comment 4

[Boris Zbarsky [:bzbarsky]]

The code that asserts looks like:

191 my_glib_log_func(const gchar *log_domain, GLogLevelFlags log_level,
192                  const gchar *message, gpointer user_data)
193 {
194   orig_log_func(log_domain, log_level, message, NULL);
195 
196   if (log_level & (G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL | G_LOG_LEVEL_WARNING)) {
197     NS_DebugBreak(NS_DEBUG_ASSERTION, message, "glib assertion", __FILE__, __LINE__);
198   }
199 }

Perhaps we should differentiate between the different log levels here?

Comment 5

[Michael Ventnor]

Attachment: Patch

This should work. It separates the warning levels so now it will only assert on something that deserves an assertion, plus it will silence every G* warning on a non-debug build.

Comment 6

[Michael Ventnor]

Attachment: Patch 2

Roc said we should keep the current behaviour.

Comment 7

[Reed Loden [:reed]]

Checking in xpfe/bootstrap/nsSigHandlers.cpp;
/cvsroot/mozilla/xpfe/bootstrap/nsSigHandlers.cpp,v  <--  nsSigHandlers.cpp
new revision: 1.57; previous revision: 1.56
done