411037 - SSL error page when built using libxul doesn't have the two buttons for get me out of here/add exception

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Raúl Porcel]

The bug is pretty simple, if you build firefox using --with-libxul-sdk=(path of xulrunner) the SSL error page doesn't have the two buttons.

This is with libxul-sdk:
http://dev.gentoo.org/~armin76/ssl1.png
This is without libxul-sdk:
http://dev.gentoo.org/~armin76/ssl.png

The page i'm trying to access is https://bugs.gentoo.org

I believe this is because the error page with the two buttons is included in en-US.jar:locale/en-US/global/netError.dtd . However the en-US.jar manifest doesn't list the global directory.

With the en-US.jar provided without libxul-sdk, the directory is included in the manifest, therefore, the error page is the correct one. With libxul-sdk it defaults to netErrorApp.dtd, which doesn't include the two buttons.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Wow, there are supposed to be buttons there!?  I think this affects us, too!  O_o

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Sounds like this might be what Neil mentioned in the last paragraph of bug 405862 comment 8.

Comment 3

[Jo Hermans]

(In reply to comment #1)
> Wow, there are supposed to be buttons there!?  I think this affects us, too! 
> O_o
> 

The buttons should appear when you click on the "Or you can add an exception…" link.

Comment 4

[Alexander Sack]

Attachment: explicitly override

Comment 5

[Raúl Porcel]

Works for me with that patch

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 295751 [details] [diff] [review]
explicitly override

r+a=me, good catch

Comment 7

[Reed Loden [:reed]]

Checking in browser/locales/jar.mn;
/cvsroot/mozilla/browser/locales/jar.mn,v  <--  jar.mn
new revision: 1.74; previous revision: 1.73
done