SSL error page when built using libxul doesn't have the two buttons for get me out of here/add exception

RESOLVED FIXED in Firefox 3 beta3

Status

()

Firefox
Build Config
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Raúl Porcel, Assigned: Alexander Sack)

Tracking

Trunk
Firefox 3 beta3
x86
Linux
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
The bug is pretty simple, if you build firefox using --with-libxul-sdk=(path of xulrunner) the SSL error page doesn't have the two buttons.

This is with libxul-sdk:
http://dev.gentoo.org/~armin76/ssl1.png
This is without libxul-sdk:
http://dev.gentoo.org/~armin76/ssl.png

The page i'm trying to access is https://bugs.gentoo.org

I believe this is because the error page with the two buttons is included in en-US.jar:locale/en-US/global/netError.dtd . However the en-US.jar manifest doesn't list the global directory.

With the en-US.jar provided without libxul-sdk, the directory is included in the manifest, therefore, the error page is the correct one. With libxul-sdk it defaults to netErrorApp.dtd, which doesn't include the two buttons.
Flags: blocking-firefox3?
Wow, there are supposed to be buttons there!?  I think this affects us, too!  O_o
Sounds like this might be what Neil mentioned in the last paragraph of bug 405862 comment 8.

Comment 3

10 years ago
(In reply to comment #1)
> Wow, there are supposed to be buttons there!?  I think this affects us, too! 
> O_o
> 

The buttons should appear when you click on the "Or you can add an exception…" link.
(Assignee)

Comment 4

10 years ago
Created attachment 295751 [details] [diff] [review]
explicitly override
Assignee: nobody → asac
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Attachment #295751 - Flags: review?(mconnor)
(Reporter)

Comment 5

10 years ago
Works for me with that patch
Comment on attachment 295751 [details] [diff] [review]
explicitly override

r+a=me, good catch
Attachment #295751 - Flags: review?(mconnor)
Attachment #295751 - Flags: review+
Attachment #295751 - Flags: approval1.9+
Keywords: checkin-needed
Checking in browser/locales/jar.mn;
/cvsroot/mozilla/browser/locales/jar.mn,v  <--  jar.mn
new revision: 1.74; previous revision: 1.73
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11

Updated

10 years ago
Flags: blocking-firefox3? → blocking-firefox3+

Updated

9 years ago
Depends on: 486826
You need to log in before you can comment on or make changes to this bug.