Closed Bug 411037 Opened 12 years ago Closed 12 years ago

SSL error page when built using libxul doesn't have the two buttons for get me out of here/add exception

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3 beta3

People

(Reporter: armin76, Assigned: asac)

References

Details

Attachments

(1 file)

The bug is pretty simple, if you build firefox using --with-libxul-sdk=(path of xulrunner) the SSL error page doesn't have the two buttons.

This is with libxul-sdk:
http://dev.gentoo.org/~armin76/ssl1.png
This is without libxul-sdk:
http://dev.gentoo.org/~armin76/ssl.png

The page i'm trying to access is https://bugs.gentoo.org

I believe this is because the error page with the two buttons is included in en-US.jar:locale/en-US/global/netError.dtd . However the en-US.jar manifest doesn't list the global directory.

With the en-US.jar provided without libxul-sdk, the directory is included in the manifest, therefore, the error page is the correct one. With libxul-sdk it defaults to netErrorApp.dtd, which doesn't include the two buttons.
Flags: blocking-firefox3?
Wow, there are supposed to be buttons there!?  I think this affects us, too!  O_o
Sounds like this might be what Neil mentioned in the last paragraph of bug 405862 comment 8.
(In reply to comment #1)
> Wow, there are supposed to be buttons there!?  I think this affects us, too! 
> O_o
> 

The buttons should appear when you click on the "Or you can add an exception…" link.
Assignee: nobody → asac
Status: NEW → ASSIGNED
Attachment #295751 - Flags: review?(mconnor)
Works for me with that patch
Comment on attachment 295751 [details] [diff] [review]
explicitly override

r+a=me, good catch
Attachment #295751 - Flags: review?(mconnor)
Attachment #295751 - Flags: review+
Attachment #295751 - Flags: approval1.9+
Checking in browser/locales/jar.mn;
/cvsroot/mozilla/browser/locales/jar.mn,v  <--  jar.mn
new revision: 1.74; previous revision: 1.73
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Flags: blocking-firefox3? → blocking-firefox3+
Depends on: 486826
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3 beta3 → mozilla3 beta3
You need to log in before you can comment on or make changes to this bug.