Closed Bug 411043 Opened 15 years ago Closed 4 years ago

nsWindowsShellService::OpenApplication should fall back to HKEY_LOCALE_MACHINE should HKEY_CURRENT_USER fail

Categories

(Firefox :: Shell Integration, defect)

Product:
Firefox
Component:
Shell Integration
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: testo.moz, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

I was looking at http://lxr.mozilla.org/mozilla1.8.0/source/browser/components/shell/src/nsWindowsShellService.cpp#821 and saw that nsWindowsShellService::OpenApplication uses HKEY_CURRENT_USER to find the location of some programs.  I was thinking that if such programs can't be found in HKEY_CURRENT_USER it should check HKEY_LOCALE_MACHINE.  It would make this function a lot more useful.  

Reproducible: Always
Note: this will be removed by bug 324361
Depends on: 324361
Version: unspecified → 2.0 Branch

With bug 324361 fixed, this code has now gone away.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.