411046 - Bidi resolution causes duplication of background images

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Simon Montagu :smontagu]

Attachment: Testcase (reduced from http://bugzilla.wikimedia.org/show_bug.cgi?id=12244)

When an inline element has a background image defined in CSS and contains text with different directionalities, the background image is repeated in each directional run.

This is a regression since Firefox 2. I haven't checked the exact regression date yet, but I strongly suspect that it is a side-effect of bug 299065.

Comment 1

[Uri Bernstein]

Yeah, almost certainly 299065. And offhand, it seems like this is going to be very difficult to fix... :-(

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We already handled backgrounds on inlines that split at line breaks, so it should be just a matter of that code handling continuations instead of next-in-flows, i.e. fairly simple. Uri, why do you think it's hard?

Comment 3

[Uri Bernstein]

(In reply to comment #2)
> We already handled backgrounds on inlines that split at line breaks,

I didn't know that (and I couldn't be bothered to check...)

> Uri, why do you think it's hard?

Because I didn't know that (and I couldn't be bothered to check...)

Comment 4

[Uri Bernstein]

Attachment: patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 295976 [details] [diff] [review]
patch

super, thanks!

Comment 6

[Uri Bernstein]

Checking in mozilla/layout/base/nsCSSRendering.cpp;
/cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v  <--  nsCSSRendering.cpp
new revision: 3.335; previous revision: 3.334
done

Comment 7

[Uri Bernstein]

This should be covered by the reftest for bug 412093, when we have it.