Created attachment 295661 [details] Testcase (reduced from http://bugzilla.wikimedia.org/show_bug.cgi?id=12244) When an inline element has a background image defined in CSS and contains text with different directionalities, the background image is repeated in each directional run. This is a regression since Firefox 2. I haven't checked the exact regression date yet, but I strongly suspect that it is a side-effect of bug 299065.
Yeah, almost certainly 299065. And offhand, it seems like this is going to be very difficult to fix... :-(
We already handled backgrounds on inlines that split at line breaks, so it should be just a matter of that code handling continuations instead of next-in-flows, i.e. fairly simple. Uri, why do you think it's hard?
(In reply to comment #2) > We already handled backgrounds on inlines that split at line breaks, I didn't know that (and I couldn't be bothered to check...) > Uri, why do you think it's hard? Because I didn't know that (and I couldn't be bothered to check...)
Assignee: nobody → uriber
Created attachment 295976 [details] [diff] [review] patch
Comment on attachment 295976 [details] [diff] [review] patch super, thanks!
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Checking in mozilla/layout/base/nsCSSRendering.cpp; /cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v <-- nsCSSRendering.cpp new revision: 3.335; previous revision: 3.334 done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
This should be covered by the reftest for bug 412093, when we have it.
Flags: in-testsuite? → in-testsuite-
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.