Closed Bug 411046 Opened 17 years ago Closed 16 years ago

Bidi resolution causes duplication of background images

Categories

(Core :: Layout: Text and Fonts, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: smontagu, Assigned: uriber)

References

Details

(Keywords: regression, testcase)

Attachments

(2 files)

When an inline element has a background image defined in CSS and contains text with different directionalities, the background image is repeated in each directional run.

This is a regression since Firefox 2. I haven't checked the exact regression date yet, but I strongly suspect that it is a side-effect of bug 299065.
Flags: blocking1.9?
Yeah, almost certainly 299065. And offhand, it seems like this is going to be very difficult to fix... :-(
Blocks: 299065
Keywords: regression, testcase
We already handled backgrounds on inlines that split at line breaks, so it should be just a matter of that code handling continuations instead of next-in-flows, i.e. fairly simple. Uri, why do you think it's hard?
(In reply to comment #2)
> We already handled backgrounds on inlines that split at line breaks,

I didn't know that (and I couldn't be bothered to check...)

> Uri, why do you think it's hard?

Because I didn't know that (and I couldn't be bothered to check...)
Assignee: nobody → uriber
Attached patch patchSplinter Review
Attachment #295976 - Flags: superreview?(roc)
Attachment #295976 - Flags: review?(roc)
Status: NEW → ASSIGNED
Comment on attachment 295976 [details] [diff] [review]
patch

super, thanks!
Attachment #295976 - Flags: superreview?(roc)
Attachment #295976 - Flags: superreview+
Attachment #295976 - Flags: review?(roc)
Attachment #295976 - Flags: review+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Checking in mozilla/layout/base/nsCSSRendering.cpp;
/cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v  <--  nsCSSRendering.cpp
new revision: 3.335; previous revision: 3.334
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Flags: in-testsuite?
Depends on: 412093
This should be covered by the reftest for bug 412093, when we have it.
Flags: in-testsuite? → in-testsuite-
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: