Closed Bug 411053 Opened 15 years ago Closed 15 years ago

xpt_dump not rebuild when libxpt.a is modified

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: arno, Assigned: arno)

Details

Attachments

(3 files, 1 obsolete file)

Hi.
when I'm in
/mozilla/xpcom/typelib/xpt
If I modify src/xpt_struct.c and run make, it rebuilds src/libxpt.a but does not rebuild tools/xpt_dump

As xpt_dump links statically libxpt.a, xpt_dump should be rebuild.

I noticed that bug is corrected if, in tools/Makefile.in, I put line
LIBS        = ../src/$(LIB_PREFIX)xpt.$(LIB_SUFFIX)

*before*

include $(topsrcdir)/config/rules.mk

I'm not quite sure, but for some reason, it seems that $(LIBS) is evaluated non lazyly in config/rules.mk; although I did not find where.
Attachment #295671 - Attachment is patch: true
Attachment #295671 - Attachment mime type: application/octet-stream → text/plain
Attachment #295669 - Attachment filename: log → normal_output
Attachment #295670 - Attachment filename: log → patched_output
Assignee: nobody → arno.@no-log.org
Attachment #295671 - Flags: superreview?(benjamin)
Attachment #295671 - Flags: review?(benjamin)
Attachment #295669 - Attachment mime type: application/octet-stream → text/plain
Attachment #295670 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 295671 [details] [diff] [review]
modification I applied to tools/Makefile.in

You probably can get rid of the "EXTRA_DEPS" hunk right below this.
Attachment #295671 - Flags: superreview?(benjamin)
Attachment #295671 - Flags: superreview+
Attachment #295671 - Flags: review?(benjamin)
Attachment #295671 - Flags: review+
Yes, it looks redundant. I've tried and it seems to work fine without the EXTRA_DEPS. I'll attach a new diff, but as old one has already been reviewed, I don't known if I should attach override the old one.
Attachment #296189 - Flags: approval1.9?
Attachment #296189 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in xpcom/typelib/xpt/tools/Makefile.in;
/cvsroot/mozilla/xpcom/typelib/xpt/tools/Makefile.in,v  <--  Makefile.in
new revision: 1.31; previous revision: 1.30
done
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Attachment #295671 - Attachment is obsolete: true
Component: xpidl → XPCOM
QA Contact: xpidl → xpcom
You need to log in before you can comment on or make changes to this bug.