3.91 KB, text/plain
4.46 KB, text/plain
947 bytes, patch
Mike Schroepfer: approval1.9+
|Details | Diff | Splinter Review|
Created attachment 295669 [details] make output after modifying src/xpt_struct.c Hi. when I'm in /mozilla/xpcom/typelib/xpt If I modify src/xpt_struct.c and run make, it rebuilds src/libxpt.a but does not rebuild tools/xpt_dump As xpt_dump links statically libxpt.a, xpt_dump should be rebuild. I noticed that bug is corrected if, in tools/Makefile.in, I put line LIBS = ../src/$(LIB_PREFIX)xpt.$(LIB_SUFFIX) *before* include $(topsrcdir)/config/rules.mk I'm not quite sure, but for some reason, it seems that $(LIBS) is evaluated non lazyly in config/rules.mk; although I did not find where.
Created attachment 295670 [details] make output after modifying src/xpt_struct.c if LIB defined before rules.mk included
Attachment #295669 - Attachment filename: log → normal_output
Attachment #295670 - Attachment filename: log → patched_output
Attachment #295669 - Attachment mime type: application/octet-stream → text/plain
Attachment #295670 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 295671 [details] [diff] [review] modification I applied to tools/Makefile.in You probably can get rid of the "EXTRA_DEPS" hunk right below this.
Yes, it looks redundant. I've tried and it seems to work fine without the EXTRA_DEPS. I'll attach a new diff, but as old one has already been reviewed, I don't known if I should attach override the old one.
Checking in xpcom/typelib/xpt/tools/Makefile.in; /cvsroot/mozilla/xpcom/typelib/xpt/tools/Makefile.in,v <-- Makefile.in new revision: 1.31; previous revision: 1.30 done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Attachment #295671 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.