Closed Bug 411133 Opened 15 years ago Closed 15 years ago

Provide mozilla-gtkmozembed and mozilla-gtkmozembed-embedding .pc files

Categories

(Toolkit Graveyard :: XULRunner, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: stransky, Assigned: stransky)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.8.1.11) Gecko/20071202 Fedora/1.1.7-1.fc8 SeaMonkey/1.1.7
Build Identifier: 

Please provide .pc config files mozilla-gtkmozembed.pc and
mozilla-gtkmozembed-embedding.pc.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch proposed patch (obsolete) — Splinter Review
Comment on attachment 295770 [details] [diff] [review]
proposed patch

>+Requires: libxul = %MOZILLA_VERSION%
>+Cflags: -I${includedir}/gtkembedmoz

Shouldn't we just use Requires: libxul-unstable here?

>+Requires: libxul-embedding = %MOZILLA_VERSION%
>+Cflags: -I${includedir}/gtkembedmoz

dito?
well libxul-embedding-unstable of course.
Why whole unstable? Does gtkembedmoz require/use anything what is missing in stable? 
yes, gtkmozembed* for instance

btw, my plain make install doesn't even have ${includedir}/gtkmozembed?
it's in ${includedir}/gtkembedmoz
$ pkg-config --variable=includedir libxul
/usr/include/xulrunner-1.9b3pre

$ ls $(pkg-config --variable=includedir libxul)/gtkmozembed
ls: /usr/include/xulrunner-1.9b3pre/gtkmozembed: No such file or directory

$ ls $(pkg-config --variable=includedir libxul)
stable	unstable

Do you have any patch in your xul build that does that or am I missing something?
Attached patch an updated patchSplinter Review
Ahh, you're right, the original is done against our modified includes. There's a new patch what should work with the official headers.
Attachment #295770 - Attachment is obsolete: true
Assignee: nobody → stransky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Attachment #295909 - Flags: review?(benjamin)
Attachment #295909 - Flags: review?(benjamin) → review+
Attachment #295909 - Flags: approval1.9?
Attachment #295909 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in xulrunner/installer/Makefile.in;
/cvsroot/mozilla/xulrunner/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.13; previous revision: 1.12
done
RCS file: /cvsroot/mozilla/xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in,v
done
Checking in xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in;
/cvsroot/mozilla/xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in,v  <--  mozilla-gtkmozembed-embedding.pc.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/xulrunner/installer/mozilla-gtkmozembed.pc.in,v
done
Checking in xulrunner/installer/mozilla-gtkmozembed.pc.in;
/cvsroot/mozilla/xulrunner/installer/mozilla-gtkmozembed.pc.in,v  <--  mozilla-gtkmozembed.pc.in
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Comment on attachment 295909 [details] [diff] [review]
an updated patch

>diff -up /dev/null mozilla/xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in
>--- /dev/null	2008-01-08 09:03:16.107043921 +0100
>+++ mozilla/xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in	2008-01-08 09:44:56.000000000 +0100

>+Name: mozilla-gtkembedmoz

Was this supposed to be mozilla-gtkembedmoz-embedding?
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.