days-from-date of leap year fails

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
10 years ago
a year ago

People

(Reporter: aaronr, Unassigned)

Tracking

({fixed1.8.1.13})

Trunk
x86
Windows XP
fixed1.8.1.13

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.55 KB, application/xhtml+xml
Details
2.26 KB, patch
aaronr
: review+
Doron Rosenberg (IBM)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
If a user tries to get days-from-date from "2008-02-29" we return NaN instead of 13938.  XSmiles and formsPlayer both return the correct value.
(Reporter)

Comment 1

10 years ago
Created attachment 295825 [details]
testcase

Comment 2

9 years ago
Created attachment 306642 [details] [diff] [review]
patch

Calculation of leap years in nsSchemaValidatorUtils::GetMaximumMonthInDayFor is incorrect. Additionally, we don't handle the case where the time string ends with fractional seconds and is not followed by a Z or +/- timezone offset.
Attachment #306642 - Flags: review?(aaronr)

Updated

9 years ago
Attachment #306642 - Flags: review?(doronr)

Updated

9 years ago
Attachment #306642 - Flags: review?(doronr) → review+
(Reporter)

Updated

9 years ago
Attachment #306642 - Flags: review?(aaronr) → review+
(Reporter)

Updated

9 years ago
Duplicate of this bug: 420253
(Reporter)

Comment 4

9 years ago
checked into trunk and 1.8 branch for msterlin
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.8.1.13
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.