Status
People
(Reporter: doronr, Assigned: doronr)
Tracking
({fixed1.8.1.12})
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
1.05 KB,
patch
|
aaronr
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
Created attachment 295829 [details] [diff] [review] the patch to fix the issue Code was removed
Attachment #295829 -
Flags: review?(aaronr)
to be clear, this patch fixes the fact that some of the mozilla/extensions/schema-validation/tests/schema-complex-test.html tests are failing.
Attachment #295829 -
Flags: review?(aaronr) → review+
(Assignee) | ||
Comment 2•11 years ago
|
||
and more importantly, that the code was there and then removed by a mega patch somehow
(Assignee) | ||
Updated•11 years ago
|
Attachment #295829 -
Flags: review?(Olli.Pettay)
Comment 3•11 years ago
|
||
Comment on attachment 295829 [details] [diff] [review] the patch to fix the issue >@@ -4761,6 +4770,7 @@ > rv = elm->GetAttribute(aAttrName, attrValue); > NS_ENSURE_SUCCESS(rv, rv); > } >+ } I assume this and the relevant block get aligned properly when checked in.
Attachment #295829 -
Flags: review?(Olli.Pettay) → review+
fixed indentation and checked into trunk for Doron.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
checked into 1.8 branch via bug 410239. Also fixed the schema testcases on 1.8 branch since they still had doron's machine hardcoded in them.
Keywords: fixed1.8.1.12
Whiteboard: xf-to-branch
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•