Build failure in cookies on ia64

RESOLVED FIXED in mozilla1.9beta3

Status

()

Core
Networking: Cookies
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Unassigned)

Tracking

Trunk
mozilla1.9beta3
Other
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

RHEL5.1 ia64, building today's trunk:

gmake[6]: Entering directory `/builddir/build/BUILD/mozilla/netwerk/cookie/src'
nsCookie.cpp
c++ -o nsCookie.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"Linux2.6.9-55.0.9\" -DOSARCH=Linux -DIMPL_NS_NET  -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/pref -I../../../dist/include/storage -I../../../dist/include   -I../../../dist/include/necko -I../../../dist/include/nspr     -I../../../dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -Werror   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsCookie.pp nsCookie.cpp
nsCookieService.cpp
c++ -o nsCookieService.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"Linux2.6.9-55.0.9\" -DOSARCH=Linux -DIMPL_NS_NET  -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/pref -I../../../dist/include/storage -I../../../dist/include   -I../../../dist/include/necko -I../../../dist/include/nspr     -I../../../dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -Werror   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsCookieService.pp nsCookieService.cpp
cc1plus: warnings being treated as errors
../../../dist/include/xpcom/nsVoidArray.h: In member function 'void nsAutoVoidArray::ResetToAutoBuffer()':
../../../dist/include/xpcom/nsVoidArray.h:193: warning: cast from 'char*' to 'nsVoidArray::Impl*' increases required alignment of target type
../../../dist/include/xpcom/nsTHashtable.h: In member function 'EntryType* nsTHashtable<EntryType>::GetEntry(typename EntryType::KeyType) const [with EntryType = nsCookieEntry]':
nsCookieService.cpp:1152:   instantiated from here
../../../dist/include/xpcom/nsTHashtable.h:164: warning: cast from 'PLDHashEntryHdr*' to 'nsCookieEntry*' increases required alignment of target type
../../../dist/include/xpcom/nsTHashtable.h: In static member function 'static void nsTHashtable<EntryType>::s_ClearEntry(PLDHashTable*, PLDHashEntryHdr*) [with EntryType = nsCookieEntry]':
../../../dist/include/xpcom/nsTHashtable.h:335:   instantiated from 'PRBool nsTHashtable<EntryType>::Init(PRUint32) [with EntryType = nsCookieEntry]'
nsCookieService.cpp:421:   instantiated from here
../../../dist/include/xpcom/nsTHashtable.h:391: warning: cast from 'PLDHashEntryHdr*' to 'nsCookieEntry*' increases required alignment of target type
../../../dist/include/xpcom/nsTHashtable.h: In static member function 'static void nsTHashtable<EntryType>::s_CopyEntry(PLDHashTable*, const PLDHashEntryHdr*, PLDHashEntryHdr*) [with EntryType = nsCookieEntry]':
../../../dist/include/xpcom/nsTHashtable.h:339:   instantiated from 'PRBool nsTHashtable<EntryType>::Init(PRUint32) [with EntryType = nsCookieEntry]'
nsCookieService.cpp:421:   instantiated from here
../../../dist/include/xpcom/nsTHashtable.h:379: warning: cast from 'const PLDHashEntryHdr*' to 'const nsCookieEntry*' increases required alignment of target type
../../../dist/include/xpcom/nsTHashtable.h: In static member function 'static PLDHashOperator nsTHashtable<EntryType>::s_EnumStub(PLDHashTable*, PLDHashEntryHdr*, PRUint32, void*) [with EntryType = nsCookieEntry]':
../../../dist/include/xpcom/nsTHashtable.h:235:   instantiated from 'PRUint32 nsTHashtable<EntryType>::EnumerateEntries(PLDHashOperator (*)(EntryType*, void*), void*) [with EntryType = nsCookieEntry]'
nsCookieService.cpp:819:   instantiated from here
../../../dist/include/xpcom/nsTHashtable.h:414: warning: cast from 'PLDHashEntryHdr*' to 'nsCookieEntry*' increases required alignment of target type
gmake[6]: *** [nsCookieService.o] Error 1
gmake[6]: Leaving directory `/builddir/build/BUILD/mozilla/netwerk/cookie/src'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/builddir/build/BUILD/mozilla/netwerk/cookie'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/builddir/build/BUILD/mozilla/netwerk'
gmake[3]: *** [libs_tier_necko] Error 2
gmake[3]: Leaving directory `/builddir/build/BUILD/mozilla'
gmake[2]: *** [tier_necko] Error 2
gmake[2]: Leaving directory `/builddir/build/BUILD/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/builddir/build/BUILD/mozilla'
make: *** [build] Error 2
Since this really isn't a cookie-specific issue, I think the fix is probably to disable WARNINGS_AS_ERRORS on ia64...

Comment 2

11 years ago
since they're all complaining about alignment through a cast, perhaps a better fix is to disable that warning globally for ia64. i bet you're seeing millions of them throughout the rest of the tree...

also, is this gcc 4.3? i had to disable WARNINGS_AS_ERRORS for cookies on plain ol' x86, since they added a bunch of pedantic-sounding warnings. but that's another bug...

Comment 3

11 years ago
Created attachment 296065 [details] [diff] [review]
disable it
Attachment #296065 - Flags: review?

Updated

11 years ago
Attachment #296065 - Flags: review? → review?(ted.mielczarek)
Comment on attachment 296065 [details] [diff] [review]
disable it

Given that we don't actually care about ia64, I'm not really concerned if hiding this warning is correct, so r=me.
Attachment #296065 - Flags: review?(ted.mielczarek) → review+

Comment 5

11 years ago
awesome. fixed.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.