41130 - Multiple select using Shift+up arrow doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[esther]

Using 2000-05-32 on win98 and mac the multiple select method of Shift+up arrow 
doesn't work when trying to multiple select mail messages in thread pane.  This 
works in 4.7 on window and mac (linux 4.7 doesn't support this).   I couldn't 
find that we support this in the spec, but it is currently working in 4.7x.  
Should it be supported in Seamonkey too.   Jennifer if you think this should be 
supported, please reassign to putterman.  

1. Launch Messenger
2. Select a a mail account which will display messages in the tread pane
3. Select a mail message and hold the Shift key down while pressing the up arrow 
on the keyboard.  

result:  only the original message you selected is selected
expected:  messages above the selected message should hightlight with each click 
of the up arrow

Note: this bug was found by [e-mail] a new intern

Comment 1

[jglick]

Yes, Shift+up arrow and Shift+down arrow should both work for multiple 
selection of messages.  Shift+up - messages above the selected message.  
Shift+down - messages below the selected message.

Comment 2

[esther]

Actually, now the result is that the messages get selected one at at time when 
moving up, but it still doesn't multiple select.

Comment 3

[scottputterman]

reassigning to hyatt.

Comment 4

[Lakespur Roca]

nomiinating Beta 3 Polish.  Necessary for keyboard dependent users.

Comment 5

[Jan Varga [:janv]]

I have fix for this. Sending patches...

Comment 6

[Jan Varga [:janv]]

Attachment: patch for treeBindings.xml

Comment 7

[Jan Varga [:janv]]

Attachment: patch for nsXULTreeOuterGroupFrame.cpp

Comment 8

[Peter Trudelle]

nsbeta3-, will still take patch when ready

Comment 9

[Pratik Dhupia]

adding myself to cc, as a keyboard user, i really want this one to be fixed. :)

Comment 10

[lchiang]

How do these patches look?  Do you need someone to review?  Perhaps you can add 
"patch" keyword.

Comment 11

[Jan Varga [:janv]]

I'll update patch to the tip and than someone can review it

Comment 12

[Jan Varga [:janv]]

Attachment: new patch

Comment 13

[lchiang]

I assume shift+down arrow should work too? 

Comment 14

[Jan Varga [:janv]]

yes it should

I also plan multiple selections with other keys (page up/down, home, end) later

Comment 15

[Jan Varga [:janv]]

Attachment: new patch, select only one item after changing "selection orientation"

Comment 16

[Jan Varga [:janv]]

ignore previous patch, I'll send new patch soon

Comment 17

[Jan Varga [:janv]]

Attachment: proposed patch

Comment 18

[Jan Varga [:janv]]

Last patch also fixes 46706 (scrolling with page up/down broken)
Bryner, can you test last one ?

Comment 19

[Jan Varga [:janv]]

Attachment: updated to the tip

Comment 20

[Brian Ryner (not reading)]

Checked in, thanks Jan!

Comment 21

[laurel]

Works OK for me using sept 15 commercial build NT 4.0, linux rh6.0 and mac OS
9.0.

I do, however, see a problem when going downward in thread pane on linux --
selections appear to duplicate last message before pane splitter when causing
the thread list to scroll.  Once the selection is stopped, display corrects.
Will log this one separately.

Comment 22

[laurel]

Display problem logged as bug 52873.