411301 - s390x trunk build fails in xptcall

Status: RESOLVED FIXED

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Using today's trunk on RHEL5.1 s390x:

gmake[9]: Entering directory `/builddir/build/BUILD/mozilla/xpcom/reflect/xptcall/src/md/unix'
xptcinvoke_linux_s390x.cpp
c++ -o xptcinvoke_linux_s390x.o -c -I../../../../../../dist/include/system_wrappers -include ../../../../../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.9-55.0.9\" -DOSARCH=Linux -DEXPORT_XPTC_API -D_IMPL_NS_COM -I./../.. -I./../../../../xptinfo/src  -I../../../../../../dist/include/string -I../../../../../../dist/include   -I../../../../../../dist/include/xpcom -I../../../../../../dist/include/nspr        -fPIC   -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -fno-strict-aliasing -fno-inline -fomit-frame-pointer -mbackchain   -DMOZILLA_CLIENT -include ../../../../../../mozilla-config.h -Wp,-MD,.deps/xptcinvoke_linux_s390x.pp xptcinvoke_linux_s390x.cpp
xptcinvoke_linux_s390x.cpp:198: error: expected constructor, destructor, or type conversion before 'XPTC_InvokeByIndex'
xptcinvoke_linux_s390x.cpp:45: warning: 'PRUint32 invoke_count_words(PRUint32, nsXPTCVariant*)' defined but not used
xptcinvoke_linux_s390x.cpp:90: warning: 'void invoke_copy_to_stack(PRUint32, nsXPTCVariant*, PRUint64*, PRUint32)' defined but not used
gmake[9]: *** [xptcinvoke_linux_s390x.o] Error 1
gmake[9]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom/reflect/xptcall/src/md/unix'
gmake[8]: *** [libs] Error 2
gmake[8]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom/reflect/xptcall/src/md'
gmake[7]: *** [libs] Error 2
gmake[7]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom/reflect/xptcall/src'
gmake[6]: *** [libs] Error 2
gmake[6]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom/reflect/xptcall'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom/reflect'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/builddir/build/BUILD/mozilla/xpcom'
gmake[3]: *** [libs_tier_xpcom] Error 2
gmake[3]: Leaving directory `/builddir/build/BUILD/mozilla'
gmake[2]: *** [tier_xpcom] Error 2
gmake[2]: Leaving directory `/builddir/build/BUILD/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/builddir/build/BUILD/mozilla'
make: *** [build] Error 2

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Note that s390 has the same exact error, except of course in the s390.cpp file

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

This is likely a regression from bug 349002 ...

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

I have a patch which I think works... will test and report back.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Created attachment 297095 [details] [diff] [review]
This fixes the build

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in to trunk.