411334 - Remove temporary group for SVG drawing on Mac

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Vlad says this is no longer neeeded. Removing it will vastly improve SVG printing on Mac, will mostly fix bug 398102 so that SVG text gets subpixel rendering (unless it's in a group of its own), and may improve performance.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 296019 [details] [diff] [review]
fix

Let's do it (and hope it doesn't break anything!)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It seems to break gearflowers :-(.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

This works.

It doesn't work for printing, where we only paint once. I'd rather have a few SVG drawings fail to print instead of all SVG drawings printing horribly. We should fix the underlying fallback issues anyway. And we could use cairo's own PDF backend if we chose.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I managed to concoct a reftest for this.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The reftest is actually testing bug 398102 to make sure that antialiasing is the same in SVG as for HTML. So this actually might not be tested properly on the tinderbox test machines because they seem to use grayscale for everything. Oh well.