41139 - Able to select multiple radio boxes by using the keyboard

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[jmraker]

Using Win32 2000053008 nightly build.

Actual Results:
  It's letting me select multiple items from the same radio group.  
Redrawing/Resizing the screen doesn't show which radio item is really selected

Expected Results:
  Only one radio item from the group should be shown as selected if one is 
selected.

Steps to reproduce:
1. Click on the first 'a'.
2. Press tab twice.
3. Press space.  (2 are selected)
   Can be repeated to select all.

This bug is also found in widgets.xul (in the samples directory) using backtabs 
in the radio boxes.
1. Click on 'Radio 2'
2. Press Shift+Tab
3. Press space. (2 are selected)

Comment 1

[jmraker]

Attachment: Testcase of bug

Comment 2

[Peter Trudelle]

confirming (using 53108 on Win98), reassigning to ben, nominating for nsbeta2

Comment 3

[Peter Trudelle]

[nsbeta2-]

Comment 4

[don]

M20

Comment 5

[Claudius Gayle]

nav triage team: [b3nav+] now = [nsbeta3+]

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

so here's what happens: you click on the widget, the radio element gets focus. 
You hit tab, and you move into the anonymous content of the widget (which is 
incorrectly taking focus). You hit tab again, etc. and you shift into the 
anonymous content of the next widget, and when you hit space, my code looks at 
which node the event was targeted at, and only sets the selected item property 
on the radiogroup (which unchecks the other elements) if the target is a radio. 

Since anonymous content is skin-specific, the solution is to place 'user-focus: 
none' on the anonymous content of widgets to prevent focus going inside them. 
This is what I have done to radio and checkbox in modern and classic/win. This 
will also fix the number of times you have to hit tab between widgets for radio 
and checkbox elements. I'll fix the other widgets later.

Comment 7

[shrirang khanzode]

verified (2000091408m18, windows)