Last Comment Bug 411391 - Fix processor handling of error conditions
: Fix processor handling of error conditions
Status: RESOLVED FIXED
:
Product: Socorro
Classification: Server Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: 0.5
Assigned To: K Lars Lohn [:lars] [:klohn]
: socorro
:
Mentors:
http://code.google.com/p/socorro/issu...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-08 18:29 PST by Samuel Sidler (old account; do not CC)
Modified: 2011-12-28 10:40 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Samuel Sidler (old account; do not CC) 2008-01-08 18:29:25 PST
Reported by bsmedberg, Jul 12, 2007

The processor has a rather hodgepodge set of error/success conditions, and
needs to report processing errors more effectively. In particular:

1) missing product/buildid should be fatal
2) error messages from processing should be reported to the log
3) python exceptions from processing should be reported to the log

And this should all be tested.

I'll take this for now, but feel free to steal it if you are inspired
Comment 1 Michael Morgan [:morgamic] 2008-04-02 01:37:09 PDT
Lars, this is lumped in with refactor -- please comment if that is incorrect.
Comment 2 K Lars Lohn [:lars] [:klohn] 2008-04-18 20:06:58 PDT
THe refactoring covers these issues:

> 1) missing product/buildid should be fatal
a dump with missing product/buildid terminates the processing of that dump.  An error is put into the log file.  Bug 421985 addresses putting an explanation of the error into the reports table.

> 2) error messages from processing should be reported to the log
the logging system is configurable as to the severity of errors logged.  Problems in processing a dump are given the error level of WARNING or ERROR.  These are logged iff the system is told to log these errors.

> 3) python exceptions from processing should be reported to the log
python exceptions with tracebacks are given a logging level of ERROR.  They will be logged iff the system is configured to save these messages.


Note You need to log in before you can comment on or make changes to this bug.