411422 - make stack signature contains search case insensitive

Status: RESOLVED WONTFIX

(Socorro :: General, task)

Description

[Samuel Sidler (old account; do not CC)]

Reported by sspitzer, Nov 27, 2007

What is the problem?

stack signature contains search is case sensitive

What is the expected behavior? What happens instead?

for crash-stats, make stack signature contains search case insensitive

if I search on "nsnav" I get no results, but if I search on "nsNav" I get
the results I'm looking for.

What version of the product are you using, and on what OS?

http://crash-stats.mozilla.com/

Please provide any additional information below.

Comment 1

[Benjamin Smedberg]

FWIW, I think this should be WONTFIX. Code is case-sensitive, and a case-insensitive search would be a performance hit on the server... unless you lowercased the frame data up front, which seems a little silly to me.

Comment 2

[(not reading, please use [e-mail] instead)]

I guess I have been spoiled by lxr and the like.

Comment 3

[Samuel Sidler (old account; do not CC)]

I think I'd actually prefer it to be case insensitive as well. Is the performance hit that bad?

Comment 4

[Michael Morgan [:morgamic]]

Would prefer not to do this.  Reopen if it's really important.

Comment 5

[Wayne Mery (:wsmwk)]

wow! I hit this today, attempting to search "compact" to catch multiple sigs, which came back not found.   

Case sensitivity is not going to be obvious to most triagers let alone the casual user, and a killer in general when typing, i.e. not doing copy and paste of sigs/frame info.

How bad is the performance hit?

Comment 6

[Tony Mechelynck [:tonymec]]

Code is case-sensitive but FAYT is case-insensitive and I don't know of any complaints about the latter.

If there is a non-negligible performance hit, maybe something could be done to alleviate it:
a) don't return case-mismatched matches if there are case-matching ones
and/or
b) search case-sensitively unless the search text is all lowercase.