Closed Bug 411463 Opened 13 years ago Closed 13 years ago

AIX Compilation error with compiler option -qlanglvl=stdc99 for trunk build source npunix.c : mozilla/modules/plugin/samples/default/unix/npunix.c", line 556.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed

Categories

(Core :: Plug-ins, defect)

Other
AIX
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9beta4

People

(Reporter: shailen.n.jain, Assigned: shailen.n.jain)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

On AIX, while compiling trunk build source with compiler option -qlanglvl=stdc99 for mozilla/modules/plugin/samples/default/unix/npunix.c, getting below compilation
errors -

mozilla/modules/plugin/samples/default/unix/npunix.c", line 556.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.
mozilla/modules/plugin/samples/default/unix/npunix.c", line 599.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.
mozilla/modules/plugin/samples/default/unix/npunix.c", line 655.54: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.




Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox Trunk build on AIX with Gnome 2.12 RPMS of 64 bit
version
2.
3.
Actual Results:  
Build fails with the above errors.

Expected Results:  
No build failure
Severity: normal → major
OS: Other → AIX
Version: unspecified → Trunk
Attached patch Patch V1 (obsolete) — Splinter Review
The official language definition doesn't allow to perform pointer math on a type void *. Using a caddr_t (char *) type in place of void * for taking the difference between two pointers.
Attachment #296107 - Flags: review?(brendan)
Component: Build Config → Plug-ins
Product: Firefox → Core
QA Contact: build.config → plugins
Attachment #296107 - Flags: superreview?(jst)
Attachment #296107 - Flags: review?(jst)
Attachment #296107 - Flags: review?(brendan)
Comment on attachment 296107 [details] [diff] [review]
Patch V1

Could we not do something like this (use char *?) for all platforms to avoid sprinkling AIX specific code throughout this code?
Attached patch Patch V2Splinter Review
Modified the code as per Johnny Stenback's review comment.
Attachment #296107 - Attachment is obsolete: true
Attachment #301656 - Flags: superreview?(jst)
Attachment #301656 - Flags: review?(jst)
Attachment #296107 - Flags: superreview?(jst)
Attachment #296107 - Flags: review?(jst)
Comment on attachment 301656 [details] [diff] [review]
Patch V2

Yeah, I like that. r+sr=jst
Attachment #301656 - Flags: superreview?(jst)
Attachment #301656 - Flags: superreview+
Attachment #301656 - Flags: review?(jst)
Attachment #301656 - Flags: review+
Assignee: nobody → shailen.n.jain
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #301656 - Flags: approval1.9?
Keywords: checkin-needed
Don't add the checkin-needed keyword until approval1.9 has been granted.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Attachment #301656 - Flags: approval1.9? → approval1.9+
Checking in modules/plugin/samples/default/unix/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npunix.c,v  <--  npunix.c
new revision: 1.14; previous revision: 1.13
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
You need to log in before you can comment on or make changes to this bug.