411463 - AIX Compilation error with compiler option -qlanglvl=stdc99 for trunk build source npunix.c : mozilla/modules/plugin/samples/default/unix/npunix.c", line 556.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

On AIX, while compiling trunk build source with compiler option -qlanglvl=stdc99 for mozilla/modules/plugin/samples/default/unix/npunix.c, getting below compilation
errors -

mozilla/modules/plugin/samples/default/unix/npunix.c", line 556.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.
mozilla/modules/plugin/samples/default/unix/npunix.c", line 599.62: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.
mozilla/modules/plugin/samples/default/unix/npunix.c", line 655.54: 1506-068 (S) Operation between types "void*" and "void*" is not allowed.




Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox Trunk build on AIX with Gnome 2.12 RPMS of 64 bit
version
2.
3.
Actual Results:  
Build fails with the above errors.

Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V1

The official language definition doesn't allow to perform pointer math on a type void *. Using a caddr_t (char *) type in place of void * for taking the difference between two pointers.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 296107 [details] [diff] [review]
Patch V1

Could we not do something like this (use char *?) for all platforms to avoid sprinkling AIX specific code throughout this code?

Comment 3

[Shailen]

Attachment: Patch V2

Modified the code as per Johnny Stenback's review comment.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 301656 [details] [diff] [review]
Patch V2

Yeah, I like that. r+sr=jst

Comment 5

[Reed Loden [:reed]]

Don't add the checkin-needed keyword until approval1.9 has been granted.

Comment 6

[Reed Loden [:reed]]

Checking in modules/plugin/samples/default/unix/npunix.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npunix.c,v  <--  npunix.c
new revision: 1.14; previous revision: 1.13
done