411479 - Use same install method for themes and extensions dropped into manager

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We currently use InstallTrigger.install for extensions and InstallTrigger.installChrome for themes. Doing this seems to be the cause of bug 257992 which we have wallpapered over. There is no real difference between the two methods since we unified the UI in bug 349603.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This just stuffs all the files into the one array. Adds icon discrimination between the types.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 296357 [details] [diff] [review]
patch rev 1

Thanks

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 296357 [details] [diff] [review]
patch rev 1

Seeking approval, this is a simple fix that makes us behave more sanely in the event that the user drops multiple themes into the UI to be installed.

Comment 4

[Mike Schroepfer]

Comment on attachment 296357 [details] [diff] [review]
patch rev 1

Dave - you have other blocker bugs you can help with?

Comment 5

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.154; previous revision: 1.153
done

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fixed a long time ago. Marking as verified.

Dave, I can still see a lot of references to installChrome on MXR for mozilla-central. Are those valid cases?

http://mxr.mozilla.org/mozilla-central/search?string=installChrome