Closed
Bug 411498
Opened 16 years ago
Closed 16 years ago
Task mode details pane doesn't show enough details
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: michael.buettner, Assigned: michael.buettner)
Details
Attachments
(1 file, 1 obsolete file)
29.33 KB,
patch
|
michael.buettner
:
review+
michael.buettner
:
ui-review+
|
Details | Diff | Splinter Review |
Details of the currently selected task are shown in the lower part of the task mode. Currently, only the task title and the description text is shown. There are a number of further properties that should be shown in this area. See [1] for the appropriate proposal. [1] http://wiki.mozilla.org/Calendar:Improving_the_Calendar_Views#Tasks
Flags: wanted-calendar0.8?
Updated•16 years ago
|
Flags: wanted-calendar0.8? → blocking-calendar0.8+
Assignee | ||
Comment 1•16 years ago
|
||
This patch carries all the necessary bits and pieces to show more details for the currently selected task. I had to touch the function which transforms a recurrence rule into its natural language counterpart since it was a bit too rigid in order to be reused flawlessly. The rest of the patch is quite straight forward.
Attachment #296964 -
Flags: ui-review?(christian.jansen)
Attachment #296964 -
Flags: review?(Berend.Cornelius)
Comment 2•16 years ago
|
||
The patch looks good I've reviewed it on Mac. I'd like to ask to yo to add add the following items to the list: Status: Needs Action In Process N% Complete Completed Completed on DATE Canceled Please also mark the "Title" text bold. If possible show the name displayed next to "From:" as link. A click on the link should open the Message compose window.
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 3•16 years ago
|
||
The patch works great and makes the taskpane look even better than before.
I could not detect anything wrong about it. During the review I also had a look at the file calendar-summary-dialog.js that was also affected by your implementation. There I noticed that you could consolidate your code
>+ if (organizer) {
>+ var name = organizer.commonName;
>+ if (!name || name.length <= 0) {
>+ if (organizer.id && organizer.id.length) {
>+ name = organizer.id;
>+ var re = new RegExp("^mailto:(.*)", "i");
>+ var matches = re.exec(name);
>+ if (matches) {
>+ name = matches[1];
>+ }
>+ }
with according code in that file. Also I noticed that progress and priority related information is not displayed in that dialog. But this is another story...
Comment 4•16 years ago
|
||
Comment on attachment 296964 [details] [diff] [review] patch v1 r=Berend
Attachment #296964 -
Flags: review?(Berend.Cornelius) → review+
Comment 5•16 years ago
|
||
I have one last suggestion:
Your css -rule
>+#calendar-task-details-grid-right {
>+ margin-left: 15em;
>+}
takes care that the second column of the grid is displayed with a certain distance to the first column. Yet it does not prevent that the column is changing its position when traveling through the task tree. I suggest to set a big min-width (e.g 12em) at the first column instead and only small left-margin at the second column.
Assignee | ||
Comment 6•16 years ago
|
||
Patch with all review comments addressed. 1) The details pane now displays the item status if available 2) 'In Process N% Complete' has been changed to 'N% Complete' 3) Title is now displayed bold 4) The organizer is now a hyperlink 5) Lowered the margin to not waste space Carrying forward r+ & ui-r+ -> Going to check this in now.
Attachment #296964 -
Attachment is obsolete: true
Attachment #297784 -
Flags: ui-review+
Attachment #297784 -
Flags: review+
Attachment #296964 -
Flags: ui-review?(christian.jansen)
Assignee | ||
Comment 7•16 years ago
|
||
patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Target Milestone: --- → 0.8
Version: Trunk → unspecified
Comment 9•16 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre (2008012818) Thunderbird/2.0.0.9 ID:2007103104 VERIFIED FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•