Task mode details pane doesn't show enough details



Lightning Only
11 years ago
11 years ago


(Reporter: Michael Büttner (no reviews TFN), Assigned: Michael Büttner (no reviews TFN))


Bug Flags:
blocking-calendar0.8 +



(1 attachment, 1 obsolete attachment)

29.33 KB, patch
Michael Büttner (no reviews TFN)
: review+
Michael Büttner (no reviews TFN)
: ui-review+
Details | Diff | Splinter Review


11 years ago
Details of the currently selected task are shown in the lower part of the task mode. Currently, only the task title and the description text is shown. There are a number of further properties that should be shown in this area. See [1] for the appropriate proposal.

[1] http://wiki.mozilla.org/Calendar:Improving_the_Calendar_Views#Tasks
Flags: wanted-calendar0.8?


11 years ago
Flags: wanted-calendar0.8? → blocking-calendar0.8+

Comment 1

11 years ago
Created attachment 296964 [details] [diff] [review]
patch v1

This patch carries all the necessary bits and pieces to show more details for the currently selected task. I had to touch the function which transforms a recurrence rule into its natural language counterpart since it was a bit too rigid in order to be reused flawlessly. The rest of the patch is quite straight forward.
Attachment #296964 - Flags: ui-review?(christian.jansen)
Attachment #296964 - Flags: review?(Berend.Cornelius)

Comment 2

11 years ago
The patch looks good I've reviewed it on Mac. I'd like to ask to yo to add
add the following items to the list:

Status: Needs Action
             In Process N% Complete
	     Completed on DATE

Please also mark the "Title" text bold. If possible show the name displayed next to "From:" as link. A click on the link should open the Message compose window.

Comment 3

11 years ago
The patch works great and makes the taskpane look even better than before.
I could not detect anything wrong about it. During the review I also had a look at the file calendar-summary-dialog.js that was also affected by your implementation. There I noticed that you could consolidate your code

>+            if (organizer) {
>+                var name = organizer.commonName;
>+                if (!name || name.length <= 0) {
>+                  if (organizer.id && organizer.id.length) {
>+                      name = organizer.id;
>+                      var re = new RegExp("^mailto:(.*)", "i");
>+                      var matches = re.exec(name);
>+                      if (matches) {
>+                          name = matches[1];
>+                      }
>+                  }

with according code in that file. Also I noticed that progress and priority related information is not displayed in that dialog. But this is another story...

Comment 4

11 years ago
Comment on attachment 296964 [details] [diff] [review]
patch v1

Attachment #296964 - Flags: review?(Berend.Cornelius) → review+

Comment 5

11 years ago
I have one last suggestion:

Your css -rule
>+#calendar-task-details-grid-right {
>+  margin-left: 15em;

takes care that the second column of the grid is displayed with a certain distance to the first column. Yet it does not prevent that the column is changing its position when traveling through the task tree. I suggest to set a big min-width (e.g 12em) at the first column instead and only small left-margin at the second column.

Comment 6

11 years ago
Created attachment 297784 [details] [diff] [review]
patch v2

Patch with all review comments addressed.

1) The details pane now displays the item status if available
2) 'In Process N% Complete' has been changed to 'N% Complete'
3) Title is now displayed bold
4) The organizer is now a hyperlink
5) Lowered the margin to not waste space

Carrying forward r+ & ui-r+ -> Going to check this in now.
Attachment #296964 - Attachment is obsolete: true
Attachment #297784 - Flags: ui-review+
Attachment #297784 - Flags: review+
Attachment #296964 - Flags: ui-review?(christian.jansen)

Comment 7

11 years ago
patch checked in on trunk and MOZILLA_1_8_BRANCH

Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Version: Trunk → unspecified

Comment 8

11 years ago
Verified with Lt 2008012900
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071031 Lightning/0.8pre (2008012818) Thunderbird/ ID:2007103104

You need to log in before you can comment on or make changes to this bug.