Last Comment Bug 411540 - No dialog asking to save event if mouse is used to quit Calendar
: No dialog asking to save event if mouse is used to quit Calendar
: dataloss
Product: Calendar
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
-- critical (vote)
: 1.0b1
Assigned To: Philipp Kewisch [:Fallen]
Depends on:
  Show dependency treegraph
Reported: 2008-01-09 11:33 PST by Gary Kwong [:gkw] [:nth10sd]
Modified: 2011-11-07 02:40 PST (History)
3 users (show)
dbo.moz: wanted‑calendar1.0+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Fix - v1 (528 bytes, patch)
2009-10-11 05:04 PDT, Philipp Kewisch [:Fallen]
ssitter: review+
Details | Diff | Splinter Review

Description User image Gary Kwong [:gkw] [:nth10sd] 2008-01-09 11:33:33 PST
(tested on ftp trunk and ftp branch nightlies, on a fresh profiles)

1. Start up Calendar.
2. Create a new event.
3. Type something in the description.
4. Decide to quit the app.

Two results for procedure #4:

if cmd-Q is pressed, a confirmation dialog (asking to save or not) is brought up.
if the mouse is used, (-> Calendar -> Quit Calendar), no dialog is brought up asking to save the data.
Comment 1 User image Gary Kwong [:gkw] [:nth10sd] 2008-01-15 22:33:41 PST
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv: Gecko/20080115 Calendar/0.8pre

Still occurs in today's branch build. (Today's trunk build fails to mount) Nominating blocking-calendar0.8 since this is potential dataloss.
Comment 2 User image Gary Kwong [:gkw] [:nth10sd] 2008-01-15 22:46:34 PST
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008011503 Calendar/0.6a1

Occurs in trunk build as well. (Apologies; I had a download error previously, re-downloaded and all was ok)
Comment 3 User image Gary Kwong [:gkw] [:nth10sd] 2008-01-24 09:32:42 PST
reproduced on Windows XP (nightly thunderbird and lightning en-US branch builds dated 20080123).

Two results' procedure after typing something in the description:

Works correctly (save event dialog comes up) if control-Q is pressed at the event window. And if mouse is used to go File -> Exit at the event window.

Works incorrectly (save event dialog does not come up) if control-Q is pressed at the Thunderbird main UI or if mouse is used to go File -> Exit at the Thunderbird main UI.
Comment 4 User image Simon Paquet [:sipaq] 2008-02-08 04:58:21 PST
This does not block the 0.8 release.
Comment 5 User image Philipp Kewisch [:Fallen] 2009-10-11 05:04:02 PDT
Created attachment 405747 [details] [diff] [review]
Fix - v1

This was quite an easy one, who would have thought! We should think about changing the "do you want to save this event" message to include the event title, i.e when the user has a bunch of events open. Since we are in string freeze, we should think about doing that in a new bug though.
Comment 6 User image Stefan Sitter 2009-11-13 09:11:25 PST
Comment on attachment 405747 [details] [diff] [review]
Fix - v1

Comment 7 User image Philipp Kewisch [:Fallen] 2009-11-15 09:01:18 PST
Pushed to comm-central <>
and comm-1.9.1  <>

Comment 8 User image Damian Szczepanik 2010-02-24 11:24:35 PST
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20100224 Calendar/1.0b2pre
Comment 9 User image Philipp Kewisch [:Fallen] 2011-11-07 02:40:32 PST
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Note You need to log in before you can comment on or make changes to this bug.