411590 - Run leak test on Thunderbird tinderboxes

Status: RESOLVED WONTFIX

(Thunderbird :: Testing Infrastructure, defect)

Description

[Joey Minta]

Certain large scale changes (e.g. STEEL, or switching the abook to mozstorage) could easily introduce new leaks into Thunderbird code.  Currently, however, it's not at all easy to detect this.  If the something like Firefox's RLk [1] test were running on the Thunderbird boxes, we would at least have a chance at catching a large segment of leaks.

[1] http://build-graphs.mozilla.org/graph/query.cgi?testname=refcnt_leaks&units=bytes&tbox=fxdbug-linux-tbox.build.mozilla.org&autoscale=1&days=7&avg=1&showpoint=2008:01:09:14:58:21,

Comment 1

[David Ascher (:davida)]

Indeed.  One large scale change which is likely to add leaks would be bundling Lightning by default, which is likely not leak-free.

Comment 2

[Wayne Mery (:wsmwk)]

Is this still legit?

and, do we have a meta bug this should be linked to, about improving our memory or test robustness story?

Comment 3

[Joshua Cranmer [:jcranmer]]

We do (refcount) leak tracking in xpcshell tests, but they don't show up as test failures (see bug 469523).

Our tinderbox builds run mailbloat, which computes bloat (max mem) and leak number for refcounts, but these also don't show up as test failures, and the related graph server output appears to be unconnected. That said, the bloat tests are spectacularly useless since (IIRC) all they test is a compose window + message send.

Conceivably, we could enable mozmill refcount leak tracking (which I can't find a bug for, surprisingly), although I think mozmill itself might be leaky.

CC'ing Standard8.

Comment 4

[Wayne Mery (:wsmwk)]

this is probably all the bug reports on record, with "test" in summary - https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=anywordssubstr;list_id=5639069;field0-0-0=short_desc;type0-0-1=substring;field0-0-1=keywords;type1-0-1=allwordssubstr;value1-0-1=mlk;resolution=---;classification=Client%20Software;classification=Components;query_format=advanced;value1-0-0=leak%20memory%20bloat;type0-0-0=anywordssubstr;value0-0-0=test;field1-0-0=short_desc;product=MailNews%20Core;product=Thunderbird;field1-0-1=keywords

Comment 5

[Mark Banner (:standard8)]

The explicit leak tests were stopped ages ago - the preferred method now is as part of test suites.