41165 - FileURL in getFolder results in Crash on Linux

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[David Epstein]

Linux only. build 2000-05-31-08.
1. Go to http://jimbob/trigger3.html
2. Enter badurl.xpi in the URL field. contains this segment:
 f = getFolder("file:///", "u/yourname"). no lead forward slash.
3. Trigger. OK.
Result: crash. no talkback.
Expected: -225 extraction error is fine.
Notes: If we put lead slash in the getFolder path (/u/yourname), it will return 
-225 which is OK since the pathway doesn't exist. If we change it to a real 
pathway, then it will install OK as long as there's a lead slash.

Comment 1

[Daniel Veditz [:dveditz]]

And of course the leading slash is wrong wrong wrong, because 
getFolder("file:///","/u") would logically result in file:////u -- that is, 
four slashes.

Crash with no talkback? Wow, hard to imagine pointing at the wrong place doing 
that much damage -- better not let the script kiddies know about this :-)

Comment 2

[Daniel Veditz [:dveditz]]

Nominating for nsbeta2 -- this sounds like a trivial thing to fix, and I really 
don't want people to start writing scripts with incorrect syntax that will 
break in PR3.

Comment 3

[David Epstein]

changed summary. After talking with Dan, the URL is valid w/o the lead slash, 
invalid with it. This is a case where "bad" is really "good"!

Comment 4

[Peter Trudelle]

[nsbeta2+]

Comment 5

[leger]

Adding crash to keyword field.

Comment 6

[Daniel Veditz [:dveditz]]

File URL's now behave properly, as they did prior to the nsIFile conversion

Comment 7

[Jimmy Lee]

Changing QA Contact to David.

Comment 8

[David Epstein]

fixed in linux build 2000-07-24-08-M17