41170 - opening the twisty for an imap server should refresh the folder list

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

we'll need to implement nsImapIncomingServer::PerformExpand() 

that gets called when the twisty is opened, or on startup, if the server is open
by default.

I'm going to re-assign this bug to jefft very soon.

Comment 1

[(not reading, please use [e-mail] instead)]

giving this to jefft.  (but I'll be checking in the code I already have to start
it.)

Comment 2

[(not reading, please use [e-mail] instead)]

ok.  I've taken jefft's code and plugged it into
nsImapIncomingServer::PerformExpand().

it picks up when we add new folders from another imap session.  not sure about
removing folders, or subscribe changes.

but at least it's better than before.

Comment 3

[leger]

What does "but at least it's better than before." mean.  Good enough for beta2? 
 More work to do here.

Comment 4

[Phil Peterson]

[nsbeta2-] No info, and it doesn't sound bad enough to hold beta2 for.

Comment 5

[Karen Huang]

Seth, can you explain more detail?
I have twisty and expand/collapse refresh folders problem on MS Exchange IMAP 
server....but it seems NMS folders list refresh is better than MS Exchange, I am 
not quite sure this bug is related to MS Exchange IMAP folders refresh problem 
or not? Can you explain? Thanks.

Comment 6

[jefft]

Please reconsider for nsbeta2+ again. The backend code is all there and I have a 
easy fix for this. What I need to do is to reset all folders to unverified 
and than perform expand. See the following diff.

Index: nsImapIncomingServer.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.cpp,v
retrieving revision 1.130
diff -c -r1.130 nsImapIncomingServer.cpp
*** nsImapIncomingServer.cpp    2000/06/09 23:28:03     1.130
--- nsImapIncomingServer.cpp    2000/06/12 15:54:53
***************
*** 635,641 ****
  NS_IMETHODIMP
  nsImapIncomingServer::PerformExpand(nsIMsgWindow *aMsgWindow)
  {
!       nsresult rv;
      nsCOMPtr<nsIFolder> rootFolder;
      rv = GetRootFolder(getter_AddRefs(rootFolder));
        if (NS_FAILED(rv)) return rv;
--- 635,641 ----
  NS_IMETHODIMP
  nsImapIncomingServer::PerformExpand(nsIMsgWindow *aMsgWindow)
  {
!     nsresult rv = ResetFoldersToUnverified(nsnull);
      nsCOMPtr<nsIFolder> rootFolder;
      rv = GetRootFolder(getter_AddRefs(rootFolder));
        if (NS_FAILED(rv)) return rv;
***************
*** 2208,2214 ****
  NS_IMETHODIMP
  nsImapIncomingServer::ReDiscoverAllFolders()
  {
-     nsresult rv = ResetFoldersToUnverified(nsnull);
      rv = PerformExpand(nsnull);
      return rv;
  }
--- 2208,2213 ----

Comment 7

[Phil Peterson]

Clearing nsbeta2- for reconsideration

Jeff, does your patch mean that we do folder discovery every time we expand or
collapse a folder? Seems like there could be some undesirable performance impact
to that. Or let me know if I'm confused :-)

Comment 8

[jefft]

No, this is for expanding the server node only. Normal folder node execute 
different code path. 

Comment 9

[leger]

Putting on [nsbeta2+][w/b minus on 6/15] radar.

Comment 10

[jefft]

Fix checked in. This also fix bug 42242.

Comment 11

[Karen Huang]

Verified on WinNT 06-13-09-M17 commercial build
Verified on Linux 06-13-08-M17 commercial build
Verified on Mac 9.04 06-13-08-M17 mozilla build

Folder pane refresh the changes between multiple clients for IMAP now...
Marking as verified.