integrate sunspider tests into talos

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: alice, Assigned: alice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

10 years ago
Created attachment 296422 [details] [diff] [review]
sunspider integration

We can always use more javascript tests.

Vlad, can you look this over to make sure that the test timing looks reasonable - I'm just using the built in pageloader timer that fires onload.
Attachment #296422 - Flags: review?(vladimir)
Comment on attachment 296422 [details] [diff] [review]
sunspider integration

Alice, can you strip out just the relevant bits for me to review?  I can't actually find what the heck I should be looking at in there.

Do all these tests just time until loading is complete? Or what?
(Assignee)

Comment 2

10 years ago
They use the pageloader timing, so that is just timing until onload fires.  I figured that that would be okay since all the action in the tests happens in the <body>.  There's really not that much to review here.  You can check out the tests in action here http://webkit.org/blog/152/announcing-sunspider-09/.  All I did was strip out the timing code for each test and create a manifest.
(Assignee)

Updated

10 years ago
Attachment #296422 - Flags: review?(vladimir) → review?(rcampbell)

Updated

10 years ago
Blocks: 413758
Comment on attachment 296422 [details] [diff] [review]
sunspider integration

bonus points if you can identify the included dna.
Attachment #296422 - Flags: review?(rcampbell) → review+
Assignee: nobody → anodelman
(Assignee)

Comment 4

10 years ago
Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v  <--  sample.config
new revision: 1.12; previous revision: 1.11
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-cube.html,v
done
Checking in page_load_test/sunspider/3d-cube.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-cube.html,v  <--  3d-cube.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-morph.html,v
done
Checking in page_load_test/sunspider/3d-morph.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-morph.html,v  <--  3d-morph.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-raytrace.html,v
done
Checking in page_load_test/sunspider/3d-raytrace.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/3d-raytrace.html,v  <--  3d-raytrace.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-binary-trees.html,v
done
Checking in page_load_test/sunspider/access-binary-trees.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-binary-trees.html,v  <--  access-binary-trees.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-fannkuch.html,v
done
Checking in page_load_test/sunspider/access-fannkuch.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-fannkuch.html,v  <--  access-fannkuch.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-nbody.html,v
done
Checking in page_load_test/sunspider/access-nbody.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-nbody.html,v  <--  access-nbody.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-nsieve.html,v
done
Checking in page_load_test/sunspider/access-nsieve.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/access-nsieve.html,v  <--  access-nsieve.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-3bit-bits-in-byte.html,v
done
Checking in page_load_test/sunspider/bitops-3bit-bits-in-byte.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-3bit-bits-in-byte.html,v  <--  bitops-3bit-bits-in-byte.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-bits-in-byte.html,v
done
Checking in page_load_test/sunspider/bitops-bits-in-byte.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-bits-in-byte.html,v  <--  bitops-bits-in-byte.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-bitwise-and.html,v
done
Checking in page_load_test/sunspider/bitops-bitwise-and.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-bitwise-and.html,v  <--  bitops-bitwise-and.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-nsieve-bits.html,v
done
Checking in page_load_test/sunspider/bitops-nsieve-bits.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/bitops-nsieve-bits.html,v  <--  bitops-nsieve-bits.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/controlflow-recursive.html,v
done
Checking in page_load_test/sunspider/controlflow-recursive.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/controlflow-recursive.html,v  <--  controlflow-recursive.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-aes.html,v
done
Checking in page_load_test/sunspider/crypto-aes.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-aes.html,v  <--  crypto-aes.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-md5.html,v
done
Checking in page_load_test/sunspider/crypto-md5.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-md5.html,v  <--  crypto-md5.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-sha1.html,v
done
Checking in page_load_test/sunspider/crypto-sha1.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/crypto-sha1.html,v  <--  crypto-sha1.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/date-format-tofte.html,v
done
Checking in page_load_test/sunspider/date-format-tofte.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/date-format-tofte.html,v  <--  date-format-tofte.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/date-format-xparb.html,v
done
Checking in page_load_test/sunspider/date-format-xparb.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/date-format-xparb.html,v  <--  date-format-xparb.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-cordic.html,v
done
Checking in page_load_test/sunspider/math-cordic.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-cordic.html,v  <--  math-cordic.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-partial-sums.html,v
done
Checking in page_load_test/sunspider/math-partial-sums.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-partial-sums.html,v  <--  math-partial-sums.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-spectral-norm.html,v
done
Checking in page_load_test/sunspider/math-spectral-norm.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/math-spectral-norm.html,v  <--  math-spectral-norm.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/regexp-dna.html,v
done
Checking in page_load_test/sunspider/regexp-dna.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/regexp-dna.html,v  <--  regexp-dna.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-base64.html,v
done
Checking in page_load_test/sunspider/string-base64.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-base64.html,v  <--  string-base64.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-fasta.html,v
done
Checking in page_load_test/sunspider/string-fasta.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-fasta.html,v  <--  string-fasta.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-tagcloud.html,v
done
Checking in page_load_test/sunspider/string-tagcloud.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-tagcloud.html,v  <--  string-tagcloud.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-unpack-code.html,v
done
Checking in page_load_test/sunspider/string-unpack-code.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-unpack-code.html,v  <--  string-unpack-code.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-validate-input.html,v
done
Checking in page_load_test/sunspider/string-validate-input.html;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/string-validate-input.html,v  <--  string-validate-input.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/sunspider.css,v
done
Checking in page_load_test/sunspider/sunspider.css;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/sunspider.css,v  <--  sunspider.css
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/sunspider.manifest,v
done
Checking in page_load_test/sunspider/sunspider.manifest;
/cvsroot/mozilla/testing/performance/talos/page_load_test/sunspider/sunspider.manifest,v  <--  sunspider.manifest
initial revision: 1.1
done
(Assignee)

Comment 5

10 years ago
Created attachment 299293 [details] [diff] [review]
push sunspider tests to stage.
Attachment #299293 - Flags: review?(rcampbell)
Attachment #299293 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 6

10 years ago
Checking in sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/sample.config,v  <--  sample.config
new revision: 1.10; previous revision: 1.9
done
Checking in sample.config.nochrome;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/sample.config.nochrome,v  <--  sample.config.nochrome
new revision: 1.4; previous revision: 1.3
done
Checking in sample.config.nogfx;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/sample.config.nogfx,v  <--  sample.config.nogfx
new revision: 1.10; previous revision: 1.9
done
(Assignee)

Comment 7

10 years ago
Created attachment 301412 [details] [diff] [review]
push sunspider to production

Ready to push to production.
Attachment #301412 - Flags: review?(rcampbell)
Attachment #301412 - Flags: review?(rcampbell) → review+

Comment 8

10 years ago
This is awesome and timely.  Rock on!
(Assignee)

Comment 9

10 years ago
Checking in production.sample.config;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/production.sample.config,v  <--  production.sample.config
new revision: 1.4; previous revision: 1.3
done
Checking in production.sample.config.nogfx;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/configs/production.sample.config.nogfx,v  <--  production.sample.config.nogfx
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other

Updated

9 years ago
Component: Release Engineering: Talos → Release Engineering
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.