411803 - Middle-clicking a folder doesn't work, unless the bookmark items have been shown

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Martijn Wargers (dead)]

When middle-clicking on a bookmark folder, the bookmark items don't open in new tabs, unless the contents of that bookmark folder has been shown before.

Regression range:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1199859180&maxdate=1199861339
I guess a regression from bug 409998.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Attachment: v1.1

Comment 3

[Simon Bünzli]

Comment on attachment 296453 [details] [diff] [review]
v1.1

A drive-by comment:

>       try {
>         let wasOpen = aNode.containerOpen;
> [...]
>       }
>       finally {
>+        if (!wasOpen)

wasOpen doesn't exist at this point, as it's restricted to the try block.

Comment 4

[Asaf Romano (gone)]

Attachment: v1.2

Thanks Simon.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 296591 [details] [diff] [review]
v1.2

>Index: browser/components/places/content/utils.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/places/content/utils.js,v
>retrieving revision 1.94
>diff -u -p -8 -r1.94 utils.js
>--- browser/components/places/content/utils.js	9 Jan 2008 06:32:30 -0000	1.94
>+++ browser/components/places/content/utils.js	11 Jan 2008 20:52:19 -0000
>@@ -1599,36 +1599,45 @@ var PlacesUtils = {
>       let contents = this.getFolderContents(aNode.itemId, false, false).root;
>       for (let i = 0; i < contents.childCount; ++i) {
>         let child = contents.getChild(i);
>         if (this.nodeIsURI(child))
>           urls.push({uri: child.uri, isBookmark: this.nodeIsBookmark(child)});
>       }
>     }
>     else {
>-      let result, oldViewer;
>+      let result, oldViewer, wasOpen;
>       try {
>         let wasOpen = aNode.containerOpen;
>+        result = aNode.parentResult;
>+        oldViewer = result.viewer;
>         if (!wasOpen) {
>-          result = aNode.parentResult;
>-          oldViewer = result.viewer;
>           result.viewer = null;
>           aNode.containerOpen = true;
>         }
>         for (let i = 0; i < aNode.childCount; ++i) {
>           // Include visible url nodes only
>           let child = aNode.getChild(i);
>-          if (child.viewIndex != -1 && this.nodeIsURI(child))
>-            urls.push({uri: child.uri, isBookmark: this.nodeIsBookmark(child)});
>+          if (this.nodeIsURI(child)) {
>+            // If the node contents is visible, add the uri only if its node is
>+            // visible. Otherwise follow viewer's collpaseDuplicates property,

nit: s/collpase/collapse/

r=me otherwise

Comment 6

[Asaf Romano (gone)]

mozilla/browser/components/places/content/utils.js 1.95

Comment 7

[P. Rutgers]

verified fix in Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv