41182 - first-time chrome: load of XUL file gives document "res:" URL

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Chris Waterson]

The first time you load a XUL document (or, every time you load it, if you've
turned off your XUL cache), the document will get a base URL that is a
"resource:" URL rather than a "chrome:" URL. This caused some of Mitch's
security checking code to go awry when it expected to find something with a
"chrome:" URL. He's since fixed it, but I'm concerned there may be other
problems waiting to happen.

I'm attaching a patch that sets the "originalURI" attribute on the resource
channel after creating it. Let me know if it looks sane (esp. warren & mscott).

Comment 1

[Chris Waterson]

Attachment: proposed fix

Comment 2

[Warren Harris]

Looks good, although checking that the result is non-null is bullshit. That 
should be handled by the NS_FAILED on the line above. If anything, assert that 
it's non-null, or better yet, let it crash on the -> operator so that the 
caller will fix their broken code that doesn't return a proper error value. 
(pet peeve)

Comment 3

[Andreas Franke (gone)]

*** Bug 41181 has been marked as a duplicate of this bug. ***

Comment 4

[Chris Waterson]

fix checked in, r=warren. i took out the offensive part.