411832 - [Oracle] Change ISOLATION_LEVEL to 'READ COMMITTED'

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Xiaoou]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022)
Build Identifier: 

Oracle LOB can not be used in group by, and we change it from LONGTEXT back to MEDIUMTEXT.
Change the ISOLATION_LEVEL from 'SERIALIZABLE' to 'READ COMMITTED' to avoid error when we file bugs at the same time.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Xiaoou]

Attachment: v1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 296458 [details] [diff] [review]
v1

  This should be two separate bugs, but I'll take it as one, for now.

>Index: Bugzilla/Install/DB.pm
> sub change_text_types {
>     my $dbh = Bugzilla->dbh; 
>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

  In that case, the change to namedqueries.query needs to come last in this function.

Comment 3

[Xiaoou]

Attachment: v2

Comment 4

[Frédéric Buclin]

(In reply to comment #2)
>   This should be two separate bugs, but I'll take it as one, for now.

I told him on IRC that a single bug was fine as the patch was small. Don't blame him! :)

Comment 5

[Frédéric Buclin]

Comment on attachment 296465 [details] [diff] [review]
v2

>Index: Bugzilla/Install/DB.pm

>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

I don't get it. As namedqueries.query is already of type LONGTEXT, aren't you going to return in all cases, and will never convert series.query to MEDIUMTEXT? I thought you would check |series.query eq 'MEDIUMTEXT'|.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 296465 [details] [diff] [review]
v2

>Index: Bugzilla/Install/DB.pm
> sub change_text_types {
>     my $dbh = Bugzilla->dbh; 
>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

  Wait, this won't upgrade installations running CVS code that have already changed series.query to LONGTEXT. You'll have to fix this some other way, like delete series.query from this method and add it on its own above --TABLE-- in this file.

Comment 7

[Xiaoou]

Attachment: v3

Comment 8

[Max Kanat-Alexander]

Comment on attachment 297773 [details] [diff] [review]
v3

Looks good to me.

Comment 9

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Oracle.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Oracle.pm,v  <--  Oracle.pm
new revision: 1.6; previous revision: 1.5
done