Closed Bug 411832 Opened 16 years ago Closed 16 years ago

[Oracle] Change ISOLATION_LEVEL to 'READ COMMITTED'

Categories

(Bugzilla :: Database, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: xiaoou.wu, Assigned: xiaoou.wu)

References

Details

Attachments

(1 file, 2 obsolete files)

v3
643 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022)
Build Identifier: 

Oracle LOB can not be used in group by, and we change it from LONGTEXT back to MEDIUMTEXT.
Change the ISOLATION_LEVEL from 'SERIALIZABLE' to 'READ COMMITTED' to avoid error when we file bugs at the same time.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch v1 (obsolete) — Splinter Review
Attachment #296458 - Flags: review?(mkanat)
Comment on attachment 296458 [details] [diff] [review]
v1

  This should be two separate bugs, but I'll take it as one, for now.

>Index: Bugzilla/Install/DB.pm
> sub change_text_types {
>     my $dbh = Bugzilla->dbh; 
>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

  In that case, the change to namedqueries.query needs to come last in this function.
Attachment #296458 - Flags: review?(mkanat) → review-
Attached patch v2 (obsolete) — Splinter Review
Attachment #296458 - Attachment is obsolete: true
Attachment #296465 - Flags: review?(mkanat)
(In reply to comment #2)
>   This should be two separate bugs, but I'll take it as one, for now.

I told him on IRC that a single bug was fine as the patch was small. Don't blame him! :)
Comment on attachment 296465 [details] [diff] [review]
v2

>Index: Bugzilla/Install/DB.pm

>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

I don't get it. As namedqueries.query is already of type LONGTEXT, aren't you going to return in all cases, and will never convert series.query to MEDIUMTEXT? I thought you would check |series.query eq 'MEDIUMTEXT'|.
Assignee: database → xiaoou.wu
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 3.2
Comment on attachment 296465 [details] [diff] [review]
v2

>Index: Bugzilla/Install/DB.pm
> sub change_text_types {
>     my $dbh = Bugzilla->dbh; 
>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

  Wait, this won't upgrade installations running CVS code that have already changed series.query to LONGTEXT. You'll have to fix this some other way, like delete series.query from this method and add it on its own above --TABLE-- in this file.
Attachment #296465 - Flags: review?(mkanat) → review-
Summary: [Oracle] Change query in table series back to MEDIUMTEXT and ISOLATION_LEVEL to 'READ COMMITTED' → [Oracle] Change ISOLATION_LEVEL to 'READ COMMITTED'
Attached patch v3Splinter Review
Attachment #296465 - Attachment is obsolete: true
Attachment #297773 - Flags: review?(mkanat)
Blocks: bz-oracle
Comment on attachment 297773 [details] [diff] [review]
v3

Looks good to me.
Attachment #297773 - Flags: review?(mkanat) → review+
Status: NEW → ASSIGNED
Flags: approval+
Checking in Bugzilla/DB/Oracle.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Oracle.pm,v  <--  Oracle.pm
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.