Closed Bug 411957 Opened 17 years ago Closed 16 years ago

Back and forward icons don't follow the KDE theme anymore (like in B2)

Categories

(Firefox :: Shell Integration, defect)

Product:
Firefox
Component:
Shell Integration
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: doutor.zero, Unassigned)

References

Details

Attachments

(1 file)

Part of the output of strace firefox.bin
123.26 KB, text/plain
Details 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011110 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011110 Minefield/3.0b3pre

In Firefox 3 beta 2, the icons of the back/forward buttons follows the KDE theme, as seen in this first screenshot below:

http://img174.imagevenue.com/img.php?image=78870_ff3_beta2_122_506lo.jpg

But, in recent (trunk) builds, the arrows don't follow the theme anymore, they appear to be use standard Gnome icons, like this:

http://img132.imagevenue.com/img.php?image=78864_ff3_trunk_122_1047lo.jpg

I'm using Mandriva 2007.1, with KDE 3.5.6 and gtk-qt-engine 0.8.

Thank you and sorry for my english.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
This is because we switched from documented ID's (gtk-go-back, gtk-go-forward) to ones that allowed us to control the direction, so that the UI would work properly for RTL users (gtk-go-back-rtl, gtk-go-back-ltr etc.)

For this to be fixed you must contact the theme engine maintainer and ask him to make images for those aliases.
So this is a problem with gtk-qt-engine, right? If this is the case, I will open a bug in the author's page.

Thanks.
Sorry, but I forgot one detail: I'm using the theme qtcurve, the GTK version of it.

I use gtk-qt-engine only to be able to choose the gtk theme I want for the gtk applications, so maybe this is a problem with qtcurve, not with the engine.

What do you think?
I thought this would be more an icon theme thing than a widget theme engine pb ? Perhaps you could try to make the symlinks in your theme and tell if that solves the pb ? (just make a symlink from gtk-go-back-rtl to the right icon in the same directory, probably /path/to/theme/<size>x<size>/actions/)
(In reply to comment #4)
> I thought this would be more an icon theme thing than a widget theme engine pb
> ? Perhaps you could try to make the symlinks in your theme and tell if that
> solves the pb ? (just make a symlink from gtk-go-back-rtl to the right icon in
> the same directory, probably /path/to/theme/<size>x<size>/actions/)

I'm using Mandriva's default icon theme, Crystal SVG and, if I understand what you suggest, I have to create new links pointing to the icons I want Firefox to use, right?

But I don't think this is a good solution, since I have to remove the links for all sizes and add new ones (and I don't know what's going to happen with the other GTK applications).

Thank you for your suggestion anyway.





You don't have to remove links. Just add new links. And it is for testing purposes. Once the real cause is found, we can decide if we need to work-around the missing icons in themes.
Ok.

I did the following, without any result: open the crystalsvg folder and, in actions subfolder of every size (16, 22, 32 and 48), I created a link with the name 'gtk-go-back-rtl.png' inside it, pointing to the icon 'back.png'.

This is what you suggest?
Sorry for the double post, but just now I realize that the problem is getting worst. With today's build the icons of the bookmark bar are missing (in front of the places, smart bookmarks and other buttons), look:

http://img19.imagevenue.com/img.php?image=65258_ff3_01-19_122_1156lo.jpg
doutor (in reply to comment 7): Yes it's what I was suggesting. It's strange that it didn't work. Does it work if it's a copy and not a link (shouldn't change anything, but still...). I cannot seem to make crystalsvg work on my machine, so I cannot experiment myself. Perhaps doing an "strace" of firefox to see which icon file it's trying to open ?

(in reply to comment 8): Mmm, I noticed that, but thought it was on purpose...
As far I can read, doing a strace shows nothing related to icons. Just copying the icon and renaming it probably won't work, since a symbolic link is seen as the real thing (gtk-go-back-rtl is already a symbolic link).

Overwriting the default gnome icons should work, but I don't want to go that far...

Thanks.


doutor: You should strace firefox-bin, and not firefox (which is a shell script)

I think that

LD_LIBRARY_PATH="/path/to/firefox/binaries" strace -o <output> /path/to/firefox/binaries/firefox-bin

should work.

I didn't succeed to get crystalsvg to work even on native gtk apps, it always falls back to the default icon theme...
Ok, I did it.

The output is quite huge (5.8 mb), so I decide to cut the part that appears to tell something about the icons and qtcurve. If you want the full file I can attach it here (if possible), or host it in some other place.
I just cut the part where information about the style and icon theme are displayed.
OK, so I understand why I didn't succeed in making crystalsvg work, there was
no freedesktop-compliant nor gtk icon names in there. I make a few symlinks,
and it works in Firefox. So making a symlink from "back.png" to
"gtk-go-back-ltr.png" doesn't work for you ? (I notice you made a link to
gtk-go-back-rtl.png", which should be an arrow to the right, and is used only
in RTL mode, that must be why it didn't work for you last time)

I don't know if it's possible to ask gtk to fallback to gtk-go-back.png before
trying to find gtk-go-back-rtl.png in fallback theme.
(In reply to comment #14)
> So making a symlink from "back.png" to
> "gtk-go-back-ltr.png" doesn't work for you ? (I notice you made a link to
> gtk-go-back-rtl.png", which should be an arrow to the right, and is used only
> in RTL mode, that must be why it didn't work for you last time).

No way.

Tried that and also to rename back to go-back (and creating a symlink to it called gtk-go-back-ltr.png). In both cases nothing happens... :-(
(In reply to comment #15)
> No way.
> 
> Tried that and also to rename back to go-back (and creating a symlink to it
> called gtk-go-back-ltr.png). In both cases nothing happens... :-(

Strange... It works for me. I did:

cd /path/to/crystalsvg/24x24/actions
ln -s back.png gtk-go-back-ltr.png

One question: do you have "gtk-..."-like names in your theme's folders ? If not, something (gtk, gtk-qt, ??) which would translate, and that thing wouldn't manage gtk-go-back-ltr correctly...
(In reply to comment #16)
> Strange... It works for me. I did:
> 
> cd /path/to/crystalsvg/24x24/actions
> ln -s back.png gtk-go-back-ltr.png

I did the same to create the links...

> One question: do you have "gtk-..."-like names in your theme's folders ? If
> not, something (gtk, gtk-qt, ??) which would translate, and that thing wouldn't
> manage gtk-go-back-ltr correctly...

There is no folder with the size 24x24, just 22/32/48. And, in this version of Mandriva, there is only one default gnome theme, in a folder called gnome, where I can find names with gtk-. Outside it there is no file or location with this type of name. 


(In reply to comment #17)

> There is no folder with the size 24x24, just 22/32/48. And, in this version of
> Mandriva, there is only one default gnome theme, in a folder called gnome,
> where I can find names with gtk-. Outside it there is no file or location with
> this type of name. 

So that explains why adding links doesn't work, since your system doesn't use filenames to lookup for icons (or at least does a translation). You'll need to discover who does that.

Depending on the result, we may morph this bug into one that asks for the ability to ask for several stock icons at the same time, which would then be looked up as in http://library.gnome.org/devel/gtk/stable/GtkIconTheme.html#gtk-icon-theme-choose-icon

The pb would then be that some RTL people wouldn't really understand why their icons are in the wrong direction (contrary to icons being in the wrong theme).
It would trade one bug for another, more likely to cause duplicates and wrong info from users.
Like I suspected in the beginning , this problem was really caused by qtcurve, since it don't map the -ltr icons correctly.

Following the discussion in this link below, I was able to solve it, editing the file 'qtcurve-gtk-icons, adding 'gtk-go-back-ltr' and 'gtk-go-forward-ltr' to it.

http://www.kde-look.org/content/show.php?content=40492&forumpage=53

So I'm closing the bug, right?
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Resolution: FIXED → INVALID
The above solution of adding entries to qtcurve-gtk-icons does not work on Opensuse 10.3 as nosuch file exists. 
While Opensuse uses QTcurve it does not use gtk-qt but rather kcm-gtk
No entries found in the above link provide a solution for systems using kcm-gtk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: