412005 - Spreadfirefox load time is extremely long

Status: RESOLVED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Jeremy Orem [:oremj]]

The spreadfirefox front page takes several seconds to load.  I investigated a bit and it looks like every time someone hits www.spreadfirefox.com we hit flickr several times.  

We should look in to on of these options:

* removing the flickr module
* caching the images
* caching the front page

Comment 1

[Justin Fitzhugh]

This is pretty bad - having the front page of the site taking 5.7 seconds (on a good day) is not OK.  Can someone look at this asap?

Comment 2

[Jeremy Orem [:oremj]]

I made one change to the flickr module, that greatly speeds up the frontpage, but I'm not sure this is the correct way to fix the problem.

Index: sites/all/modules/flickr/flickr.inc
===================================================================
--- sites/all/modules/flickr/flickr.inc	(revision 9605)
+++ sites/all/modules/flickr/flickr.inc	(working copy)
@@ -53,7 +53,7 @@
  * @return
  *   an array with the the result of the request, or FALSE on error.
  */
-function flickr_request($method, $args, $cacheable = FALSE, $return_errors = TRUE) {
+function flickr_request($method, $args, $cacheable = TRUE, $return_errors = TRUE) {
   // Add in additional parameters then sort them for signing.
   $args['api_key'] = trim(variable_get('flickr_api_key', ''));
   $args['method'] = $method;

Comment 3

[Justin Fitzhugh]

paul - can you take a look at tuning the site?

Comment 4

[Paul Booker]

(In reply to comment #1)
> This is pretty bad - having the front page of the site taking 5.7 seconds (on a
> good day) is not OK.  Can someone look at this asap?
> 

Thanks for feedback Jeremy.

Absolutely, if the site is taking more than a few seconds to load that is bad

I am not sure what triggered the problem it maybe work checking that there are no problems with apache  (is something outside requesting lots of apache  threads, ..) 

Comment 5

[Paul Booker]

Thanks  Jeremy ,

This is the correct way to fix the problem . This change is something that i made but did not change back . I also  made an additional change to the call to
flickr_request so that now it looks as follows ..

function flickr_request($method, $args, $cacheable = TRUE, $return_errors = FALSE) {

Please  commit sites/all/modules/flickr/flickr.inc
Committed revision 9613.

Thanks Paul



(In reply to comment #2)
> I made one change to the flickr module, that greatly speeds up the frontpage,
> but I'm not sure this is the correct way to fix the problem.
> 
> Index: sites/all/modules/flickr/flickr.inc
> ===================================================================
> --- sites/all/modules/flickr/flickr.inc (revision 9605)
> +++ sites/all/modules/flickr/flickr.inc (working copy)
> @@ -53,7 +53,7 @@
>   * @return
>   *   an array with the the result of the request, or FALSE on error.
>   */
> -function flickr_request($method, $args, $cacheable = FALSE, $return_errors =
> TRUE) {
> +function flickr_request($method, $args, $cacheable = TRUE, $return_errors =
> TRUE) {
>    // Add in additional parameters then sort them for signing.
>    $args['api_key'] = trim(variable_get('flickr_api_key', ''));
>    $args['method'] = $method;
> 

Comment 6

[Paul Booker]

(In reply to comment #3)
> paul - can you take a look at tuning the site?

I have made one change on /admin/settings/performance increasing the minimum cache lifetime from 5 minutes to 10 minutes.

Notes on this page state that ..

"On high-traffic sites it can become necessary to enforce a minimum cache lifetime. The minimum cache lifetime is the minimum amount of time that will go by before the cache is emptied and recreated. A larger minimum cache lifetime offers better performance, but users will not see new content for a longer period of time."

Where drupal says "users will not see new content for a longer period of time." it is my understanding that the range of applicability here is to anonymous users only. So hopefully  the above change is a good call .

Paul

Comment 7

[Justin Fitzhugh]

I have nothing to do with fixing the perf on this site - it's assigned to you guys.

Comment 8

[Paul Booker]

I'm closing this ticket as i think we have fixed the problem