Closed
Bug 412059
Opened 17 years ago
Closed 17 years ago
"Impersonate this user" link on editusers.cgi uses incorrect filter
Categories
(Bugzilla :: User Accounts, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: reed, Assigned: reed)
Details
Attachments
(1 file)
1.05 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Noticed this while I was working on another bug.
<a href="relogin.cgi?action=prepare-sudo&target_login=
[%- otheruser.login FILTER html %]">Impersonate this user</a>
That "html" filter should be "url_quote" instead, or else e-mail addresses that have characters like '+' in them will not be escaped properly.
Attachment #296681 -
Flags: review?(LpSolit)
![]() |
||
Comment 1•17 years ago
|
||
Comment on attachment 296681 [details] [diff] [review]
patch - v1
Yes, this fixes the problem. r=LpSolit
Attachment #296681 -
Flags: review?(LpSolit) → review+
Assignee | ||
Updated•17 years ago
|
Flags: approval?
Flags: approval3.0?
![]() |
||
Comment 2•17 years ago
|
||
This bug also exists in Bugzilla 2.22. Let's take it on this branch too.
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval2.22+
Flags: approval+
Target Milestone: Bugzilla 3.0 → Bugzilla 2.22
Assignee | ||
Comment 3•17 years ago
|
||
tip
Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v <-- userdata.html.tmpl
new revision: 1.12; previous revision: 1.11
done
BUGZILLA-3_0-BRANCH
Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v <-- userdata.html.tmpl
new revision: 1.8.2.2; previous revision: 1.8.2.1
done
BUGZILLA-2_22-BRANCH
Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v <-- userdata.html.tmpl
new revision: 1.5.2.1; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•