412138 - mdn extension assumes onStartRunningURL has been successful [@nsMsgMdnGenerator::OnStopRunningUrl]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Joey Minta]

Attachment: patch v1

The mdn generator assumes that onStartRunningURL has been called, and thus that m_file is non-null.  Violating this assumption crashes immediately.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 296773 [details] [diff] [review]
patch v1

-    m_file->Remove(PR_FALSE);
+    if (m_file)
+        m_file->Remove(PR_FALSE);

nit: please use 2 space indentation.

Comment 2

[Joey Minta]

Nits picked, checked in

Checking in mailnews/extensions/mdn/src/nsMsgMdnGenerator.cpp;
/cvsroot/mozilla/mailnews/extensions/mdn/src/nsMsgMdnGenerator.cpp,v  <--  nsMsgMdnGenerator.cpp
new revision: 1.30; previous revision: 1.29
done