Closed Bug 412154 Opened 16 years ago Closed 16 years ago

Creating events with custom recurrence rule fails [Error: getElementValue is not defined]

Categories

(Calendar :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: advax, Assigned: Fallen)

References

Details

(Keywords: regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12pre) Gecko/20080112 Calendar/0.8pre

The Gecko/20080112 build for Linux, as installed by 0.8pre auto-update, cannot
create a custom recurrence rule (e.g. with COUNT or UNTIL)

Also, in earlier builds the recurrence editor options changed when weekly, monthly
or annually were selected to allow BYMONTHDAY or BYDAY to be specified. In the
20080112 build the options remain fixed at "every n days/every weekday"


Reproducible: Always

Steps to Reproduce:
1. In event editor, select "custom" for "repeat" option
2. Set repeat values
3. Click "OK"
Actual Results:  
Sunbird hangs - custom rrule window stays open
Error console shows e.g.
Error: getElementValue is not defined
Source File: chrome://calendar/content/sun-calendar-event-dialog-recurrence.js
Line: 527

Expected Results:  
Custom rrule window closes, rrule window shows "Custom", custom settings are saved
to event.

Tried creating a new empty profile, new calendar. Still happens, as with
editing an existing calendar.

If "Cancel" is clicked, custom rrule window closes and recurrence rule
shows as e.g. "daily"
Confirmed as regression: Works in Sunbird 0.8pre (2008-01-11-05)
                         Fails in Sunbird 0.8pre (2008-01-12-06)

Checkins during regression range: http://tinyurl.com/3dc84r
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Linux → All
Hardware: PC → All
Summary: Jan 12 Linux build cannot create custom recurrence rule → Creating events with custom recurrence rule fails [Error: getElementValue is not defined]
Bug 402325 moved getElementValue() from calendar-dialog-utils.js and calUtils.js causing the regression.
Blocks: 402325
Flags: blocking-calendar0.8?
Attached patch Fix v1Splinter Review
Sorry, missed that one
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #296816 - Flags: review?
Attachment #296816 - Flags: review? → review?(mschroeder)
Comment on attachment 296816 [details] [diff] [review]
Fix v1

r=mschroeder
Attachment #296816 - Flags: review?(mschroeder) → review+
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Target Milestone: --- → 0.8
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified in latest nightly build 20080114 -> task is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.