412176 - Update Catalan Wikipedia search plugin to support suggestions

Status: RESOLVED FIXED

(Mozilla Localizations :: ca / Catalan, defect)

Description

[Toni Hermoso Pulido]

Attachment: patch for Catalan wikipedia searchplugin

The search plugin Wikipedia offers on wikipedia.org implements the MozSearch
suggestions feature.

Let's update the Wikipedia plugin in the Catalan localization of Firefox 3 to do
the same.

based on bug 411728 .

Comment 1

[Marek Stępień [:marcoos, inactive]]

You may want to change this URL:
http://ca.wikipedia.org/wiki/Especial:Search
to this:
http://ca.wikipedia.org/wiki/Especial:Cerca

Comment 2

[Toni Hermoso Pulido]

Attachment: updated patch

After comments

Comment 3

[Toni Hermoso Pulido]

done! Thanks Marek!

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 297081 [details] [diff] [review]
updated patch

Add a <Param name="sourceid" value="mozilla-search"/> instead of the limit=20? The first is a good thing, and used in all other our wp plugins, and the latter seems to be unsupported anyway.

Comment 5

[Toni Hermoso Pulido]

Attachment: updated patch with mozilla-search param

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 297801 [details] [diff] [review]
updated patch with mozilla-search param

r=me with another nit, can you change the <ShortName> to "Viquipèdia (Català)", too? Then Firefox will recognize that you already have a search plugin when going to ca.wikipedia.org.

No need for another patch, just do that locally before checking in. And please use a check-in message referencing this bug and my review, something like "bug 412176, add suggestions to wikipedia, and cleanup, r=[e-mail]" should work.