Closed Bug 412176 Opened 15 years ago Closed 15 years ago

Update Catalan Wikipedia search plugin to support suggestions

Categories

(Mozilla Localizations :: ca / Catalan, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: toniher, Assigned: toniher)

Details

Attachments

(1 file, 2 obsolete files)

The search plugin Wikipedia offers on wikipedia.org implements the MozSearch
suggestions feature.

Let's update the Wikipedia plugin in the Catalan localization of Firefox 3 to do
the same.

based on bug 411728 .
Attachment #296829 - Flags: approval1.9?
Attached patch updated patch (obsolete) — Splinter Review
After comments
Attachment #296829 - Attachment is obsolete: true
Attachment #296829 - Flags: approval1.9?
done! Thanks Marek!
Attachment #297081 - Flags: approval1.9?
Attachment #297081 - Flags: approval1.9? → review?
Attachment #297081 - Flags: review? → review?(l10n)
Comment on attachment 297081 [details] [diff] [review]
updated patch

Add a <Param name="sourceid" value="mozilla-search"/> instead of the limit=20? The first is a good thing, and used in all other our wp plugins, and the latter seems to be unsupported anyway.
Attachment #297081 - Flags: review?(l10n) → review-
Attachment #297081 - Attachment is obsolete: true
Attachment #297801 - Flags: review?
Attachment #297801 - Flags: review? → review?(l10n)
Comment on attachment 297801 [details] [diff] [review]
updated patch with mozilla-search param

r=me with another nit, can you change the <ShortName> to "Viquipèdia (Català)", too? Then Firefox will recognize that you already have a search plugin when going to ca.wikipedia.org.

No need for another patch, just do that locally before checking in. And please use a check-in message referencing this bug and my review, something like "bug 412176, add suggestions to wikipedia, and cleanup, r=l10n@mozilla.com" should work.
Attachment #297801 - Flags: review?(l10n) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.