412193 - Update nb-NO wikipedia plugin for suggestions

Status: RESOLVED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Håvard Mork]

Attachment: proposed diff on wikipedia-NO.xml for trunk

We want to update nb-NO wikipedia plugin to support suggestions.

Comment 1

[Håvard Mork]

on trunk, of course.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 296846 [details] [diff] [review]
proposed diff on wikipedia-NO.xml for trunk

r-, please change the <ShortName> to "Wikipedia (Norsk (bokmål))", too, so that wp won't offer a new plugin for download when you're there. And the url in the SearchForm should be Spesial:Søk, too.

Comment 3

[Håvard Mork]

Thanks for review.
The opensearch descriptor at http://no.wikipedia.org/w/opensearch_desc.php contains a borked ShortName. I am contacting norwegian wikipedia to get this fixed.

Comment 4

[Håvard Mork]

There are also restrictions in length of ShortName in the OpenSearch 1.1 draft.

Bug tracker for wikimedia bug:
http://bugzilla.wikimedia.org/show_bug.cgi?id=12723

Comment 5

[Mic Berman]

Havard - how are you making out? I can try my contacts if you wish? Brion Vibber
Please advise

Comment 6

[Håvard Mork]

Thank you for following up on this. No progress (waiting did not help). If you could make contacts to possibly accelerate the Wikimedia bugfix that'd be really helpful.

Comment 7

[Mic Berman]

i have pinged our contact at wikipedia, hopefully they can address before final release

Comment 8

[Brion Vibber]

Have resolved our https://bugzilla.wikimedia.org/show_bug.cgi?id=12723 as fixed. Code updated to be a bit friendlier, using the language code instead of the longer language name. (The description/shortname can also be customized per site to be nicer.)

After this change is pushed out, the ShortName for site in question will be 'Wikipedia (nb)'.

Comment 9

[Håvard Mork]

Attachment: proposed patch on wikipedia-NO.xml

Thank you, Brion, for looking into this so quickly.

Requesting approval for landing the search plugin change.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 306368 [details] [diff] [review]
proposed patch on wikipedia-NO.xml

Thanks. Please use |cvs diff -up8N| for generating patches in the future.

Comment 11

[Håvard Mork]

Checking in wikipedia-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/wikipedia-NO.xml,v  <--  wikipedia-NO.xml
new revision: 1.3; previous revision: 1.2
done