Closed Bug 412193 Opened 14 years ago Closed 13 years ago

Update nb-NO wikipedia plugin for suggestions

Categories

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mail, Assigned: mail)

References

Details

Attachments

(1 file, 1 obsolete file)

We want to update nb-NO wikipedia plugin to support suggestions.
on trunk, of course.
Status: NEW → ASSIGNED
Attachment #296846 - Attachment description: proposed diff on wikipedia-NO.xml → proposed diff on wikipedia-NO.xml for trunk
Attachment #296846 - Flags: review?(l10n)
Comment on attachment 296846 [details] [diff] [review]
proposed diff on wikipedia-NO.xml for trunk

r-, please change the <ShortName> to "Wikipedia (Norsk (bokmål))", too, so that wp won't offer a new plugin for download when you're there. And the url in the SearchForm should be Spesial:Søk, too.
Attachment #296846 - Flags: review?(l10n) → review-
Thanks for review.
The opensearch descriptor at http://no.wikipedia.org/w/opensearch_desc.php contains a borked ShortName. I am contacting norwegian wikipedia to get this fixed.
There are also restrictions in length of ShortName in the OpenSearch 1.1 draft.

Bug tracker for wikimedia bug:
http://bugzilla.wikimedia.org/show_bug.cgi?id=12723
Whiteboard: needs-gavin
Havard - how are you making out? I can try my contacts if you wish? Brion Vibber
Please advise
Whiteboard: needs-gavin → needs-patch
Thank you for following up on this. No progress (waiting did not help). If you could make contacts to possibly accelerate the Wikimedia bugfix that'd be really helpful.
i have pinged our contact at wikipedia, hopefully they can address before final release
Have resolved our https://bugzilla.wikimedia.org/show_bug.cgi?id=12723 as fixed. Code updated to be a bit friendlier, using the language code instead of the longer language name. (The description/shortname can also be customized per site to be nicer.)

After this change is pushed out, the ShortName for site in question will be 'Wikipedia (nb)'.
Thank you, Brion, for looking into this so quickly.

Requesting approval for landing the search plugin change.
Attachment #296846 - Attachment is obsolete: true
Attachment #306368 - Flags: review?(l10n)
Whiteboard: needs-patch → needs-gavin
Comment on attachment 306368 [details] [diff] [review]
proposed patch on wikipedia-NO.xml

Thanks. Please use |cvs diff -up8N| for generating patches in the future.
Attachment #306368 - Flags: review?(l10n) → review+
Whiteboard: needs-gavin
Checking in wikipedia-NO.xml;
/l10n/l10n/nb-NO/browser/searchplugins/wikipedia-NO.xml,v  <--  wikipedia-NO.xml
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.